Closed Bug 1732162 Opened 3 years ago Closed 3 years ago

Fix behaviour of OOM during incremental XDR encoding

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Consistency checks can fail if there is an OOM during increment stencil xdr encoding. This is benign, but it is easy enough to fix the root cause so we should keep the assert in place instead of relaxing it.

Add the stencil to XDR before instantiating so failures (for OOM, etc) fail the
delazification in the same way a parsing OOM would. This makes code easier to
reason about and lets us keep conservative asserts.

Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12f12739008b
Fix behaviour of OOM during incremental XDR encoding. r=arai
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: