1732194 - Fix non-unified build error in image/

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, task, P3)

Description

[Chris Peterson [:cpeterson]]

Building with ac_add_options --disable-unified-build on macOS hits the following -Wunused-const-variable warning-as-error:

image/decoders/icon/nsIconURI.cpp:39:22 [-Wunused-const-variable] unused variable 'kIconURICID'.

kIconURICID was added in bug 1583044. The only use of kIconURICID was later removed in bug 1589337, leaving kIconURICID still defined but unused.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1732194 - Fix non-unified build error in image/. r?tnikkel

Building with ac_add_options --disable-unified-build on macOS hits the following -Wunused-const-variable warning-as-error:

image/decoders/icon/nsIconURI.cpp:39:22 [-Wunused-const-variable] unused variable 'kIconURICID'.

kIconURICID was added in bug 1583044. The only use of kIconURICID was later removed in bug 1589337, leaving kIconURICID still defined but unused.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1732194 - Make some nsIconURI.cpp variables const and a function static. r?tnikkel

These are just small clean-ups. They're not non-unified build errors.

The function extractAttributeValue can be made static and doesn't need a forward declaration. All the callers of this function are in this .cpp file, after the function definition.

Depends on D126419

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7ea3f63682a
Fix non-unified build error in image/. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/bda89b20f8ae
Make some nsIconURI.cpp variables const and a function static. r=tnikkel

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c7ea3f63682a
https://hg.mozilla.org/mozilla-central/rev/bda89b20f8ae