1732208 - [clang 13] unused-but-set-variable bulk fix

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1732208 - Silence the unused-but-set-variable warning in gfx.

gfx/2d/SourceSurfaceD2D1.cpp(201,20): error: variable 'options' set but not used [-Werror,-Wunused-but-set-variable]
D2D1_MAP_OPTIONS options;
^
gfx/thebes/gfxDWriteFontList.h(269,13): error: variable 'hr' set but not used [-Werror,-Wunused-but-set-variable]
HRESULT hr = S_OK;
^
gfx/thebes/gfxGDIFontList.cpp(1020,12): error: variable 'cmapLoaded' set but not used [-Werror,-Wunused-but-set-variable]
bool cmapLoaded = false;
^
gfx/thebes/gfxMacPlatformFontList.mm:1771:10: error: variable 'isStandardFace' set but not used [-Werror,-Wunused-but-set-variable]
bool isStandardFace = false;
^
gfx/thebes/gfxPlatformFontList.cpp(1064,18): error: variable 'rejectedFallbackVisibility' set but not used [-Werror,-Wunused-but-set-variable]
FontVisibility rejectedFallbackVisibility = FontVisibility::Unknown;
^
gfx/vr/service/OculusSession.cpp(1329,12): error: variable 'bNewController' set but not used [-Werror,-Wunused-but-set-variable]
bool bNewController = false;
^

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1732208 - Silence the unused-but-set-variable warning in ipc.

ipc/chromium/src/chrome/common/ipc_channel_win.cc(133,8): error: variable 'waited' set but not used [-Werror,-Wunused-but-set-variable]
bool waited = false;
^
ipc/mscom/InterceptorLog.cpp(183,12): error: variable 'rv' set but not used [-Werror,-Wunused-but-set-variable]
nsresult rv = mThread->Dispatch(
^

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1732208 - Silence the unused-but-set-variable warning in js/src.

vm/TraceLogging.cpp:1685:12: error: variable 'totalJSTime' set but not used [-Werror,-Wunused-but-set-variable]
uint32_t totalJSTime = 0;
^
wasm/WasmBinary.h:175:15: error: variable 'assertByte' set but not used [-Werror,-Wunused-but-set-variable]
uint8_t assertByte = assertBits & 0x7f;
^
jit/x86-shared/MacroAssembler-x86-shared.cpp:406:11: error: variable 'diffG' set but not used [-Werror,-Wunused-but-set-variable]
int32_t diffG = set.gprs().size() * sizeof(intptr_t);
^
jit/x86-shared/MacroAssembler-x86-shared.cpp:404:12: error: variable 'numFpu' set but not used [-Werror,-Wunused-but-set-variable]
unsigned numFpu = fpuSet.size();
^
jit/x86-shared/MacroAssembler-x86-shared.cpp:455:11: error: variable 'diffG' set but not used [-Werror,-Wunused-but-set-variable]
int32_t diffG = set.gprs().size() * sizeof(intptr_t);
^
jit/x86-shared/MacroAssembler-x86-shared.cpp:453:12: error: variable 'numFpu' set but not used [-Werror,-Wunused-but-set-variable]
unsigned numFpu = fpuSet.size();
^
jit/x86-shared/MacroAssembler-x86-shared.cpp:503:12: error: variable 'numFpu' set but not used [-Werror,-Wunused-but-set-variable]
unsigned numFpu = fpuSet.size();
^

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1732208 - Silence the unused-but-set-variable warning in js/xpconnect.

js/xpconnect/src/XPCJSRuntime.cpp:2438:10: error: variable 'gcThingTotal' set but not used [-Werror,-Wunused-but-set-variable]
size_t gcThingTotal = 0;
^

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1732208 - Silence the unused-but-set-variable warning in parser.

parser/html/nsHtml5StreamParser.cpp:1046:10: error: variable 'totalRead' set but not used [-Werror,-Wunused-but-set-variable]
size_t totalRead = 0;
^

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1732208 - Silence the unused-but-set-variable warning in platform-linux-android.cpp.

platform-linux-android.cpp:199:9: error: variable 'r' set but not used [-Werror,-Wunused-but-set-variable]
int r = sem_init(&mMessage2, /* pshared */ 0, 0);
^
platform-linux-android.cpp:206:9: error: variable 'r' set but not used [-Werror,-Wunused-but-set-variable]
not used [-Werror,-Wunused-but-set-variable]
int r = sem_destroy(&mMessage2);
^

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1732208 - Silence the unused-but-set-variable warning in toolkit/crashreporter.

toolkit/crashreporter/breakpad-client/windows/crash_generation/minidump_generator.cc(319,35): error: variable 'dump_exception_pointers' set but not used [-Werror,-Wunused-but-set-variable]
MINIDUMP_EXCEPTION_INFORMATION* dump_exception_pointers = NULL;
^

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1732208 - Silence the unused-but-set-variable warning in widget.

widget/windows/nsAppShell.cpp(685,10): error: variable 'uiMessage' set but not used [-Werror,-Wunused-but-set-variable]
bool uiMessage = false;
^
widget/windows/TaskbarPreview.cpp(370,11): error: variable 'hr' set but not used [-Werror,-Wunused-but-set-variable]
HRESULT hr;
^

Comment 9

[Mike Hommey [:glandium]]

Attachment: Bug 1732208 - Silence the unused-but-set-variable warning in xpcom.

xpcom/tests/gtest/TestAvailableMemoryWatcherWin.cpp(130,22): error: variable 'x' set but not used [-Werror,-Wunused-but-set-variable]
volatile uint8_t x = 0;
^
xpcom/tests/gtest/TestAvailableMemoryWatcherWin.cpp(152,12): error: variable 'consumed' set but not used [-Werror,-Wunused-but-set-variable]
size_t consumed = 0;
^
xpcom/tests/gtest/TestSTLWrappers.cpp:48:7: error: variable 'rv' set but not used [-Werror,-Wunused-but-set-variable]
int rv = 1;
^

Comment 10

[Mike Hommey [:glandium]]

Attachment: Bug 1732208 - Stop disabling unused-but-set-variable warning.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ec6f0c93be9
Silence the unused-but-set-variable warning in gfx. r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/23d04c1a252e
Silence the unused-but-set-variable warning in ipc. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/7e04dd613276
Silence the unused-but-set-variable warning in js/src. r=jandem
https://hg.mozilla.org/integration/autoland/rev/3799a2ddc4da
Silence the unused-but-set-variable warning in js/xpconnect. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/d7e13f9ba1d3
Silence the unused-but-set-variable warning in parser. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/bf67b9659820
Silence the unused-but-set-variable warning in platform-linux-android.cpp. r=gerald
https://hg.mozilla.org/integration/autoland/rev/30d2381f3062
Silence the unused-but-set-variable warning in toolkit/crashreporter. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/3e99d43f5199
Silence the unused-but-set-variable warning in widget. r=cmartin
https://hg.mozilla.org/integration/autoland/rev/72cb687968f8
Silence the unused-but-set-variable warning in xpcom. r=xpcom-reviewers,mccr8

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2ec6f0c93be9
https://hg.mozilla.org/mozilla-central/rev/23d04c1a252e
https://hg.mozilla.org/mozilla-central/rev/7e04dd613276
https://hg.mozilla.org/mozilla-central/rev/3799a2ddc4da
https://hg.mozilla.org/mozilla-central/rev/d7e13f9ba1d3
https://hg.mozilla.org/mozilla-central/rev/bf67b9659820
https://hg.mozilla.org/mozilla-central/rev/30d2381f3062
https://hg.mozilla.org/mozilla-central/rev/3e99d43f5199
https://hg.mozilla.org/mozilla-central/rev/72cb687968f8

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc5a8394ce5e
Stop disabling unused-but-set-variable warning. r=firefox-build-system-reviewers,mhentges

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/cc5a8394ce5e