1732216 - ./mach ide vscode errors due to function not existing

Status: RESOLVED FIXED

(Developer Infrastructure :: Developer Environment Integration, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

It appears as though some recent changes in mach (perhaps bug 1696251) changed how ./mach ide vscode is implemented, and the command no longer functions correctly. The following error is emitted:

AttributeError: module 'mozbuild.build_commands' has no attribute '_run_make'

  File "/path/to/gecko/python/mozbuild/mozbuild/backend/mach_commands.py", line 64, in run
    rc = build_commands._run_make(

This appears to refer to https://searchfox.org/mozilla-central/rev/1749ba14c2ebe200855802c478780122135727f2/python/mozbuild/mozbuild/backend/mach_commands.py#67, which is calling a function which does not exist anymore. It appears as though there are a couple of other calls to build_commands._run_make which I expect will also no longer function correctly (https://searchfox.org/mozilla-central/search?q=build_commands._run_make&path=).

Comment 1

[Andreas Farre [:farre]]

Attachment: Bug 1732216 - Make ./mach ide vscode work with Mach commands as functions. r=andi!

Comment 2

[Andi [:andi]]

The issue that was causing this, https://hg.mozilla.org/mozilla-central/rev/53b1fa0faa6d78f7cf72f9cbe3dc85221a04eea3, has been backed out.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1696251