Closed Bug 1732249 Opened 2 months ago Closed 2 months ago

Crash in [@ mozilla::net::nsHttpNTLMAuth::GenerateCredentials]

Categories

(Core :: Networking: HTTP, defect)

defect

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox92 --- unaffected
firefox93 --- unaffected
firefox94 + fixed

People

(Reporter: aryx, Assigned: valentin)

References

(Regression)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

Nightly updates have been halted for this.

[@ mozilla::net::nsHttpNTLMAuth::GenerateCredentials] has 11 crashes from 3 installations, [@ mozilla::net::nsHttpConnection::OnReadSegment] 3 crashes from 3 installations.

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/a6a0a714-efed-4d81-8085-071820210923

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll mozilla::net::nsHttpNTLMAuth::GenerateCredentials netwerk/protocol/http/nsHttpNTLMAuth.cpp:334
1 xul.dll mozilla::net::nsHttpChannelAuthProvider::GenCredsAndSetEntry netwerk/protocol/http/nsHttpChannelAuthProvider.cpp:366
2 xul.dll mozilla::net::nsHttpChannelAuthProvider::GetCredentialsForChallenge netwerk/protocol/http/nsHttpChannelAuthProvider.cpp:974
3 xul.dll mozilla::net::nsHttpChannelAuthProvider::GetCredentials netwerk/protocol/http/nsHttpChannelAuthProvider.cpp:641
4 xul.dll mozilla::net::nsHttpChannelAuthProvider::ProcessAuthentication netwerk/protocol/http/nsHttpChannelAuthProvider.cpp:183
5 xul.dll mozilla::net::nsHttpChannel::ContinueProcessResponse3 netwerk/protocol/http/nsHttpChannel.cpp:2332
6 xul.dll mozilla::net::nsHttpChannel::ContinueProcessResponse1 netwerk/protocol/http/nsHttpChannel.cpp:2182
7 xul.dll mozilla::net::nsHttpChannel::OnStartRequest netwerk/protocol/http/nsHttpChannel.cpp:6850
8 xul.dll nsInputStreamPump::OnInputStreamReady netwerk/base/nsInputStreamPump.cpp:374
9 xul.dll nsInputStreamReadyEvent::Run xpcom/io/nsStreamUtils.cpp:94
Flags: needinfo?(dd.mozilla)
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED

There are two different crashes in this bug.
I think we should create another bug for [@ mozilla::net::nsHttpConnection::OnReadSegment ].

Thank you, created bug 1732256 for [@ mozilla::net::nsHttpConnection::OnReadSegment].

Crash Signature: [@ mozilla::net::nsHttpConnection::OnReadSegment] [@ mozilla::net::nsHttpNTLMAuth::GenerateCredentials] → [@ mozilla::net::nsHttpNTLMAuth::GenerateCredentials]
Blocks: 1732257

Clear ni to avoid confusion.

Flags: needinfo?(dd.mozilla)

Note this fix makes sure we don't crash.
The absence of a server cert might still cause the NTLM auth to fail.

Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c5fb4b924b54
Check if secInfo->GetServerCert returns a null cert r=necko-reviewers,kershaw
Pushed by abutkovits@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/d65d205e61d8
Check if secInfo->GetServerCert returns a null cert r=necko-reviewers,kershaw
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.