1732256 - Crash in [@ mozilla::net::nsHttpConnection::OnReadSegment]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/3cf56bd9-9faf-4408-b48f-cae580210923

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(!mTlsHandshakeComplitionPending)

Top 10 frames of crashing thread:

0 xul.dll mozilla::net::nsHttpConnection::OnReadSegment netwerk/protocol/http/nsHttpConnection.cpp:1725
1 xul.dll mozilla::net::Http2Session::FlushOutputQueue netwerk/protocol/http/Http2Session.cpp:683
2 xul.dll mozilla::net::Http2Session::GenerateRstStream netwerk/protocol/http/Http2Session.cpp:942
3 xul.dll mozilla::net::Http2Session::CleanupStream netwerk/protocol/http/Http2Session.cpp:1227
4 xul.dll mozilla::net::Http2Session::CloseTransaction netwerk/protocol/http/Http2Session.cpp:3796
5 xul.dll mozilla::net::nsHttpConnectionMgr::OnMsgCancelTransaction netwerk/protocol/http/nsHttpConnectionMgr.cpp:2064
6 xul.dll mozilla::net::ConnEvent::Run netwerk/protocol/http/nsHttpConnectionMgr.cpp:175
7 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1142
8 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:466
9 xul.dll mozilla::net::nsSocketTransportService::Run netwerk/base/nsSocketTransportService2.cpp:1190

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: When TLS handshake completion is pending it may happen that nss and necko are out of sync.

The previous check was incorrect.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c76c679849d7
When TLS handshake completion is pending it may happen that nss and necko are out of sync. r=necko-reviewers,kershaw,valentin

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c76c679849d7