Comments on OpenPGP related changes to Composer
Categories
(MailNews Core :: Security: OpenPGP, enhancement)
Tracking
(Not tracked)
People
(Reporter: KaiE, Unassigned)
References
Details
At this page https://un.poivron.org/~nf/thunderbird-openpgp/
a diff is available based on revision de35d92fd3ea.
I'd like to use this bug to collect comments on the patch.
|
Reporter | |
Comment 1•4 years ago
|
||
Turn off encryption for the account (no key configured).
When opening a new composer window, encryption is enabled - although it cannot be used.
...
Turn on encryption. Enter one recipient without key. You get a warning line. Turn off encryption. The line persists (it should go away).
Turn on encryption. A duplicate line for the same email address appears.
...
Nothing happens if I click the warning line.
...
Warning line doesn't disappear after I obtain and accept a key.
|
||
Comment 2•4 years ago
|
||
Turn off encryption for the account (no key configured).
When opening a new composer window, encryption is enabled - although it
cannot be used.
This is not expected and I can't reproduce it.
I tried to configure only 1 account with either:
- No e2ee encryption configured
- An OpenPGP key but not enabled
Each time I got a unavailable (greyed out) Encryption split button and Encryption menu. I could send an email unencrypted.
We might prefer hiding these 2 entirely unless at least 1 account has encryption configured.
Is that what you mean?
Does the prototype behaves different for you?
Turn on encryption. Enter one recipient without key. You get a warning
line. Turn off encryption. The line persists (it should go away).
This is not expected and I can't reproduce it. Key notifications appear and disappear correctly as I turn encryption on and off.
Turn on encryption. A duplicate line for the same email address appears.
This is not expected and I can't reproduce it. The patch deduplicates recipients by using a (case insensitive) Set() line 171.
I tried entering 3 times the address unavailable@example.com and got only 1 notification.
Nothing happens if I click the warning line.
The "Search on Key Servers..." button calls back KeyLookupHelper.lookupAndImportByEmail line 469. It has no visual feedback but does stuff in the background (like in daily).
Try searching my key and you it should be downloaded from keys.openpgp.org after almost 1 minute. Lines should appear in the console.
I wanted to wait until we design more this part of the flow before implementing something better. I agree it's a known issue until then.
Warning line doesn't disappear after I obtain and accept a key.
I documented this known issue in my doc:
https://un.poivron.org/~nf/thunderbird-openpgp/#known-issues
I didn't know how to make this work and need some help from you here.
I'm worried to see that our builds still behave very differently. I'm very new to Thunderbird dev and I'm interested in hearing suggestions on how to proceed to make our 2 builds behave in the same way.
|
|
||
Comment 3•4 years ago
|
||
Our work on bug 1627956 will cover this.
Description
•