1732334 - CSS Shape Editor is broken on remote frame when Fission is enabled

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to https://ffx-devtools-css-path-editor-in-iframe.glitch.me/
2. Right click on the orange/red part and click "Inspect"
3. The inspector should open, and have the <div class=clipped> element selected
4. In the rule view, click on the css shape button

Expected results

The CSS Shape Editor is displayed

Actual results

Nothing happens

---

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1732334 - [devtools] Fix CSS Shape Editor on iframe with dedicated target. r=jdescottes.

Depends on D126067

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Patch is on its way

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1107e4f2779f
[devtools] Fix CSS Shape Editor on iframe with dedicated target. r=jdescottes.

Comment 4

[Cristian Tuns]

Backed out for causing mochitest failures.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06e2c1336902
[devtools] Fix CSS Shape Editor on iframe with dedicated target. r=jdescottes.

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/06e2c1336902

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

that's a feature that is regressed with Fission, so I guess it would be better to uplift it

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9243254 [details]
Bug 1732334 - [devtools] Fix CSS Shape Editor on iframe with dedicated target. r=jdescottes.

Beta/Release Uplift Approval Request

• User impact if declined: CSS Shape Editor won't work on remote iframes when Fission is enabled
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Go to https://ffx-devtools-css-path-editor-in-iframe.glitch.me/

1. Right click on the orange/red part and click "Inspect"
2. The inspector should open, and have the <div class=clipped> element selected
3. In the rule view, click on the css shape button

-> The CSS Shape Editor is displayed

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): DevTools only change, with automated test
• String changes made/needed:

Comment 10

[Ciprian Georgiu, Desktop QA]

Reproduced this bug on an affected Nightly (2021-09-23), using STR from comment 0.

The issue is verified as fixed on latest Nightly 95.0a1, under macOS 11, Win 10 x64 and Ubuntu 18.04 x64.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9243254 [details]
Bug 1732334 - [devtools] Fix CSS Shape Editor on iframe with dedicated target. r=jdescottes.

Fixes a devtools regression with Fission enabled, which is expected to go to full rollout with Fx94. Approved for 94.0b8.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a19435599b55

Comment 13

[Ciprian Georgiu, Desktop QA]

The issue is also verified as fixed on Beta 94.0b8, under macOS 11, Win 11 x64 and Ubuntu 18.04 x64.