1732352 - Should we keep layers.async-pan-zoom.enabled pref?

Status: NEW

(Core :: Panning and Zooming, task)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

layers.async-pan-zoom.enabled is always true in the current mozilla-central:

• https://searchfox.org/mozilla-central/search?q=layers.async-pan-zoom.enabled&path=
• https://searchfox.org/mozilla-central/search?q=name%3A+layers.async-pan-zoom.enabled&path=&case=false&regexp=false

And it's used by gfxPlatform::AsyncPanZoomEnabled(). However, now, in almost conditions, whether turn on APZ or not does not depend on its value.

So I think we got a chance to remove this layers.async-pan-zoom.enabled pref from StaticPrefList.yaml now.

Comment 1

[Darkspirit]

In bug 1726431 comment 7 I could confirm that the bug did not occur with layers.async-pan-zoom.enabled disabled.

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Ah, I see. I don't touch this.

Comment 3

[Botond Ballo [:botond]]

It's a good question to ask whether we should retain the ability to disable APZ.

Note, this is not related to the Layers removal. The pref is in layers.* for the same reason that APZ code is in gfx/layers/ -- that's just the place where we put compositor-side features at the time.

It's true that disabling APZ is a less and less supported configuration. In particular, Fission requires APZ.

That said, having the pref around can still be useful for diagnostic purposes (see e.g. comment 1) -- so, my inclination is to leave it in as long as not bothering anyone.