ctrl+q / control+q warning should revert to normal close warning behavior when turned off
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
People
(Reporter: mozilla, Unassigned)
Details
Attachments
(2 files)
|
3.61 KB,
patch
|
Details | Diff | Splinter Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Firefox/94.0
Steps to reproduce:
- Uncheck "Confirm before quitting with Ctrl+Q"
- Check "Confirm before closing multiple tabs"
- Open multiple tabs.
- Press Ctrl+Q.
Actual results:
All tabs close without warning.
Expected results:
There should be a warning that multiple tabs will be closed.
The attached patch implements the behavior proposed in this bug report.
When a single tab is closed, a warning will be shown only when browser.warnOnQuitShortcut is true and ctrl+q is used.
When multiple tabs (or windows) are closed, a warning will be shown whenever one of the following occurs:
- browser.tabs.warnOnClose is true
- browser.warnOnQuitShortcut is true and ctrl+q is used
|
||
Comment 3•4 years ago
|
||
I believe the actual result is the expected result in this case. If Firefox is closed by clicking on the "X" button, then the close warning is displayed, but if the "Confirm before quitting with Ctrl+Q" is unchecked, then the warning will no longer be displayed when closed from the keyboard shortcut (CTRL+Q).
I'm setting this on the Tabbed Browser component in order to get a Dev's opinion on this.
The problem is when there are multiple tabs open and browser.tabs.warnOnClose is true. The expected behavior should be that there will be a warning, but there isn't when browser.warnOnQuitShortcut is false.
This appears to have been resolved by afe05f311e80
Description
•