1732446 - [Windows] Close Shortcuts doesn't offer close modal dialog with browser.tabs.warnOnClose = true

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Adrian Florinescu [:aflorinescu]]

[Description:]

While "Confirm while closing multiple tabs" is enabled, shortcuts should display close confirmation.

[Environment:]

Windows 10

[Steps:]

1. New profile, about:preferences#general, enable "Confirm while closing multiple tabs".
2. Ctrl+T open several new tabs.
3. Access File/Exit.
   3'. Use shortcut for File/Exit - Ctrl+Shift+Q
   3". Use Alt+F4

[Actual Result:]

3. Close confirmation is displayed.
   3'. Browser just quits, no confirmation is displayed.
   3''. Browser just quits, no confirmation is displayed.

[Expected Result:]

The behavior of the Ctrl+Shift+Q shortcut, the File menu and Alt+F4 need to be aligned and to my understanding while the "Confirm while closing multiple tabs" is selected (non-default 94 option), the user should get the modal close warning.

[Regression Range:]

N/A - new feature

Comment 1

[Adrian Florinescu [:aflorinescu]]

Setting S3 severity (forgot to add it @ creation)

Comment 2

[Adrian Florinescu [:aflorinescu]]

I think my understanding of the described behavior from this issue might be a bit amiss, blocking with bug 1732643.

Comment 3

[:Gijs (he/him)]

I'm kind of confused - I agree something is wrong here, but I am seeing different results on current nightly.

File > Exit: warning
Ctrl-Shift-Q: no warning
Alt-F4: warning

Maybe it depends where focus is when using Alt-F4? Can you do a screencast and/or provide more precise detail about what tabs are open when you hit that shortcut?

The Ctrl-Shift-Q bit is a bug anyway, so I'll investigate that in the meantime.

Comment 4

[Adrian Florinescu [:aflorinescu]]

(In reply to :Gijs (he/him) from comment #3)

I'm kind of confused - I agree something is wrong here, but I am seeing different results on current nightly.

This is due to my initial confusion, now the preferences details solves my confusion.

Alt-F4: warning

Uncertain at this point, I might've been messing around with browser.warnOnQuit from what I can see on the profiles history. I'll keep an eye open on this and spin it to a different bug if I can reproduce it with default config.

Maybe it depends where focus is when using Alt-F4? Can you do a screencast and/or provide more precise detail about what tabs are open when you hit that shortcut?

The Ctrl-Shift-Q bit is a bug anyway, so I'll investigate that in the meantime.

This was the original bug, but I've added the 3" point before figuring I don't fully understand the prefs. For clarity, let's continue tracking here the Ctrl-Shift-Q.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1732446 - fix multiple tab warning for quit shortcut usage on Windows, r?NeilDeakin,mhowell

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afe05f311e80
fix multiple tab warning for quit shortcut usage on Windows, r=NeilDeakin,mhowell

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/afe05f311e80

Comment 9

[Mathew Hodson]

Last good revision: a8b9260fbdef0f3600dc0b8e2e245cb0f82c3470
First bad revision: 9f39ead09bf362121599a4965136529e55880de7
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a8b9260fbdef0f3600dc0b8e2e245cb0f82c3470&tochange=9f39ead09bf362121599a4965136529e55880de7

Can you mark this as Regressed by bug 1726736

Comment 10

[Negritas Sergiu, Desktop QA]

Hello! I have managed to reproduce the issue with firefox 94.0a1 (2021-09-24) on Windows 10. I can confirm that the issue is fixed with firefox 94.0b9 and 95.0a1(2021-10-22) on Windows 10.

I will update the flags and resolution of this issue.