Closed Bug 1732648 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30912 - nfc: Convert some web tests from HTML to pure JS.

Categories

(Core :: DOM: Device Interfaces, task, P4)

Product:
Core
Component:
DOM: Device Interfaces
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30912 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30912
Details from upstream follow.

Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> wrote:

nfc: Convert some web tests from HTML to pure JS.

Nothing has changed in the test contents, but this makes it possible to
format them via clang-format (and removes some HTML boilerplate from
them as well).

Change-Id: Ifb2cb7aae19d9ecc4920895974f7c4775515fac8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172625
Reviewed-by: François Beaufort \<beaufort.francois@gmail.com>
Reviewed-by: Reilly Grant \<reillyg@chromium.org>
Commit-Queue: Raphael Kubo da Costa \<raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/main@{#923932}

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 2 subtests

Status Summary

Firefox

OK : 3
FAIL: 13

Chrome

OK : 3
FAIL: 13

Safari

OK : 3
FAIL: 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/web-nfc/NDEFMessage_constructor.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
NDEFMessage constructor without init dict: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFMessage constructor with null init dict: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFMessage constructor without NDEFMessageInit#records field: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFMessage constructor with NDEFMessageInit#records being empty: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFMessage constructor with a text record: FAIL (Chrome: FAIL, Safari: FAIL)
/web-nfc/NDEFReadingEvent_constructor.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
NDEFReadingEvent constructor without init dict: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReadingEvent constructor failed to construct its NDEFMessage: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReadingEvent constructor with null serialNumber: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReadingEvent constructor with serialNumber not present: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReadingEvent constructor with valid parameters: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReadingEvent constructor does not set NDEFRecord#lang for any text records it embeds: FAIL (Chrome: FAIL, Safari: FAIL)
/web-nfc/nfc_permission.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
Deny nfc permission should work.: FAIL (Chrome: FAIL, Safari: FAIL)
Grant nfc permission should work.: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/web-nfc/NDEFMessage_constructor.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
/web-nfc/NDEFReadingEvent_constructor.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
/web-nfc/nfc_permission.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ca1bd937952
[wpt PR 30912] - nfc: Convert some web tests from HTML to pure JS., a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9eb4b701b560
[wpt PR 30912] - nfc: Convert some web tests from HTML to pure JS., a=testonly

https://hg.mozilla.org/mozilla-central/rev/9eb4b701b560

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.