Closed Bug 1732650 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30899 - FSA: Split up move() tests and update expectations

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30899 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30899
Details from upstream follow.

Austin Sullivan <asully@chromium.org> wrote:

FSA: Split up move() tests and update expectations

move() is currently only supported for file handles. This CL splits the
tests into separate files (testing moving files vs. directories) so
that tests can be disabled per-file rather than per-test.

Bug: 1140805, 1250534
Change-Id: Iaa599cb2a8c9c277e81c2e302ec4685ec18befd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3171919
Commit-Queue: Austin Sullivan \<asully@chromium.org>
Reviewed-by: Marijn Kruisselbrink \<mek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#923939}

PR 30899 applied with additional changes from upstream: ac39068db09c1c65f4d4306d45bc85c4670bc3f1, b534806a0203f0fefbf698bf65e9cac989c085ef

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 9 subtests

Status Summary

Firefox

OK : 8
FAIL: 78

Chrome

OK : 8
PASS: 52
FAIL: 26

Safari

OK : 8
FAIL: 78

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.html
move(dir, name) to rename an empty directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) to rename a non-empty directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, "") to move an empty directory to a new directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) to move an empty directory to a new directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, "") to move a non-empty directory to a new directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) to move a non-empty directory to a new directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, "") can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) to move a directory within itself fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) to move a directory within itself and rename fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir) to move a directory within a descendent fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) to move a directory within a descendent fails: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.worker.html
move(dir, name) to rename an empty directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) to rename a non-empty directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, "") to move an empty directory to a new directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) to move an empty directory to a new directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, "") to move a non-empty directory to a new directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) to move a non-empty directory to a new directory: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, "") can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) to move a directory within itself fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) to move a directory within itself and rename fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir) to move a directory within a descendent fails: FAIL (Chrome: FAIL, Safari: FAIL)
move(dir, name) to move a directory within a descendent fails: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemDirectoryHandle-rename.https.any.worker.html
rename(name) to rename an empty directory: FAIL (Chrome: FAIL, Safari: FAIL)
rename("") to rename an empty directory fails: FAIL (Chrome: FAIL, Safari: FAIL)
rename(name) to rename a non-empty directory: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemDirectoryHandle-rename.https.any.html
rename(name) to rename an empty directory: FAIL (Chrome: FAIL, Safari: FAIL)
rename("") to rename an empty directory fails: FAIL (Chrome: FAIL, Safari: FAIL)
rename(name) to rename a non-empty directory: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemFileHandle-move.https.any.worker.html
move(dir, name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, "") to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, "") can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) while the destination file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) while the destination file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
/file-system-access/sandboxed_FileSystemFileHandle-move.https.any.html
move(dir, name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, "") to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, "") can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
move(dir) while the destination file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
move(dir, name) while the destination file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
/file-system-access/sandboxed_FileSystemFileHandle-rename.https.any.worker.html
rename(name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
rename("") to rename a file fails: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
rename(dir) should rename to stringified dir object: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with a trailing period should fail: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) while the destination file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
/file-system-access/sandboxed_FileSystemFileHandle-rename.https.any.html
rename(name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
rename("") to rename a file fails: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
rename(dir) should rename to stringified dir object: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with a trailing period should fail: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
rename(name) while the destination file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08ca563b22c2
[wpt PR 30899] - FSA: Split up move() tests and update expectations, a=testonly
https://hg.mozilla.org/integration/autoland/rev/352b18e7b596
[wpt PR 30899] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6427dc728664
[wpt PR 30899] - FSA: Split up move() tests and update expectations, a=testonly
https://hg.mozilla.org/integration/autoland/rev/63fbb3a1c898
[wpt PR 30899] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.