1732692 - [Monochromatic Themes] Residual line is displayed between tab bar and toolbar

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: residual line between tab and toolbar

Affected versions

• Fx94.0a1

Affected platforms

• Windows 10
• Ubuntu 20.04

Preconditions
Set browser.theme.temporary.monochromatic.enabled = true
Select any monochromatic theme.

Steps to reproduce

1. Launch Firefox.
2. Observe the tab bar and the toolbar.

Expected result

• There is no 'separator', the color change is done directly.

Actual result

• There is a residual line separating the tab bar from the toolbar.

Regression range

• Not a regression.

Additional notes

• Please note that the issue occurs with all the monochromatic themes.
• The 'old' themes (Default, Light, Dark and Alpenglow) don't have this issue.

Comment 2

[Harry Twyford]

We need to set toolbar_top_separator: "transparent" in the theme manifests.

Comment 3

[Harry Twyford]

Attachment: Bug 1732692 - Set toolbar_top_separator to transparent. r?dao,amy

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38463ee0a61f
Set toolbar_top_separator to transparent. r=dao

Comment 5

[Amy Churchwell [:amy]]

Comment on attachment 9244818 [details]
Bug 1732692 - Set toolbar_top_separator to transparent. r?dao,amy

Beta/Release Uplift Approval Request

• User impact if declined: Visual bug of a residual line between tab bar and toolbar.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only change.
• String changes made/needed:

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/38463ee0a61f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244818 [details]
Bug 1732692 - Set toolbar_top_separator to transparent. r?dao,amy

Approved for 94.0b4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/94631531ecb3

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is still reproducible with Lush-Balanced theme, on Windows 10 an Ubuntu 20.04.

All the other themes are fixed. The separator is no longer visible. In both nightly and beta build.

Comment 10

[Amy Churchwell [:amy]]

Attachment: Bug 1732692 - Set toolbar_top_separator to transparent for lush balanced theme. r?dao,harry

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/132d9b4f70ed
Set toolbar_top_separator to transparent for lush balanced theme. r=dao,harry

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/132d9b4f70ed

Comment 13

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed in latest nightly on Windows 10 and Ubuntu 20.04. Waiting for the uplift to close out the issue as verified fixed.

Comment 14

[Harry Twyford]

Amy, could you please request uplift on your additional patch?

Comment 15

[Amy Churchwell [:amy]]

Comment on attachment 9245347 [details]
Bug 1732692 - Set toolbar_top_separator to transparent for lush balanced theme. r?dao,harry

Beta/Release Uplift Approval Request

• User impact if declined: Visual bug of a residual line between tab bar and toolbar.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only change.
• String changes made/needed:

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9245347 [details]
Bug 1732692 - Set toolbar_top_separator to transparent for lush balanced theme. r?dao,harry

Approved for 94.0b8, thanks.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c302d3b06ea4

Comment 18

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 94.0b9 and 95.0b4, on Win 10 x64, Ubuntu 20.04 x64 and macOS 10.15.