1732775 - ChannelWrapper and nsIHttpChannel are different meanings/values for suspend/resume

Status: NEW

(WebExtensions :: Request Handling, defect, P3)

Description

[Shane Caraveo (:mixedpuppy)]

ChannelWrapper uses a boolean to keep itself from doing repeat calls to nsIHttpChannel suspend/resume. However, it also returns that flag in ChannelWrapper::Suspended.

nsHttpChannel uses a counter (mSuspendCount) for repeat calls to suspend/resume.

Anyone with channel access can suspend/resume, and if that is followed with a ChannelWrapper:Suspended call, the result will not be accurate.

If any ChannelWrapper code depends (now or in the future) on ChannelWrapper:Suspended or its internal mSuspended member as a reliable indication that the channel is suspended, it could be operating incorrectly.

If any consumer of ChannelWrapper expects that the channel is suspended or resumed by using channel wrapper, there is a non-zero chance that it is incorrect.

Comment 1

[Shane Caraveo (:mixedpuppy)]

This is documented in the webidl.

My concern is that mSuspended could get used in the future for something under the assumption that it reflects the state of the underlying channel.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.