Closed Bug 1732840 Opened 4 years ago Closed 4 years ago

Fix non-unified build errors in webaudio code

Categories

(Core :: Web Audio, task, P3)

task

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

Building with ac_add_options --disable-unified-build on macOS hits the following warnings-as-errors:

dom/media/GraphDriver.cpp:594:21: warning: code will never be executed [-Wunreachable-code]
dom/media/webaudio/blink/HRTFPanner.cpp:43:16 [-Wunused-const-variable] unused variable 'RenderingQuantum'

Building with ac_add_options --disable-unified-build on macOS hits the following warnings-as-errors:

dom/media/GraphDriver.cpp:594:21: warning: code will never be executed [-Wunreachable-code]
dom/media/webaudio/blink/HRTFPanner.cpp:43:16 [-Wunused-const-variable] unused variable 'RenderingQuantum'

Blocks: non-unified
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7aacb543c706 Fix non-unified build errors in webaudio code. r=padenot
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: