Closed Bug 1732844 Opened 1 year ago Closed 1 year ago

Fix non-unified build errors in dom/media/webrtc/

Categories

(Core :: WebRTC, task, P3)

task

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Building with ac_add_options --disable-unified-build on macOS hits the following warnings-as-errors:

dom/media/webrtc/common/browser_logging/WebRtcLog.cpp:29:16 [-Wunused-const-variable] unused variable 'default_log_name'
dom/media/webrtc/MediaEngineDefault.cpp:102:3 [-Wunreachable-code-loop-increment] loop will run at most once (loop increment never executed)
dom/media/webrtc/MediaEngineDefault.cpp:547:7 [-Wunreachable-code] code will never be executed

dom/media/webrtc/MediaEngineDefault.cpp:102:3 [-Wunreachable-code-loop-increment] loop will run at most once (loop increment never executed)
dom/media/webrtc/MediaEngineDefault.cpp:547:7 [-Wunreachable-code] code will never be executed
dom/media/webrtc/common/browser_logging/WebRtcLog.cpp:29:16 [-Wunused-const-variable] unused variable 'default_log_name'

Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bd147f6107a
Fix non-unified build errors in dom/media/webrtc/. r=webrtc-reviewers,ng
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.