1732844 - Fix non-unified build errors in dom/media/webrtc/

Status: RESOLVED FIXED

(Core :: WebRTC, task, P3)

Description

[Chris Peterson [:cpeterson]]

Building with ac_add_options --disable-unified-build on macOS hits the following warnings-as-errors:

dom/media/webrtc/common/browser_logging/WebRtcLog.cpp:29:16 [-Wunused-const-variable] unused variable 'default_log_name'
dom/media/webrtc/MediaEngineDefault.cpp:102:3 [-Wunreachable-code-loop-increment] loop will run at most once (loop increment never executed)
dom/media/webrtc/MediaEngineDefault.cpp:547:7 [-Wunreachable-code] code will never be executed

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1732844 - Fix non-unified build errors in dom/media/webrtc/. r?#webrtc-reviewers

dom/media/webrtc/MediaEngineDefault.cpp:102:3 [-Wunreachable-code-loop-increment] loop will run at most once (loop increment never executed)
dom/media/webrtc/MediaEngineDefault.cpp:547:7 [-Wunreachable-code] code will never be executed
dom/media/webrtc/common/browser_logging/WebRtcLog.cpp:29:16 [-Wunused-const-variable] unused variable 'default_log_name'

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bd147f6107a
Fix non-unified build errors in dom/media/webrtc/. r=webrtc-reviewers,ng

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8bd147f6107a