1732851 - Illegible black-on-black buttons in high contrast themes

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Valentin Villenave]

Attachment: Capture du 2021-09-28 09-34-03.png

This looks like a less severe rerun of bug 1721173 and/or bug 1728797.

Thanks to hardcoded colors, some buttons (such as accountActionsDropdown)
may appear displayed in black-on-black when in pressed state.

See attached.

Comment 1

[Alessandro Castellani [:aleca]]

Ah, we missed that, sorry.
Is this on daily and not affecting 91, right?
Thanks for the report.

Richard, can you take a look at this?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1732851-open-text-color.patch

The toolkit common.css sets only on hover (also when the popup is hovered) the text color. My patch fixes it also when it is only open but the mouse is anywhere.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9243282 [details] [diff] [review]
1732851-open-text-color.patch

Review of attachment 9243282 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this so quickly.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9894ad9af906
Set in in-content pages a text color when a button or menulist is open but not hovered. r=aleca

Comment 5

[Magnus Melin [:mkmelin]]

(91 affected, right?)

Comment 6

[Alessandro Castellani [:aleca]]

(In reply to Magnus Melin [:mkmelin] from comment #5)

(91 affected, right?)

Yes, confirmed.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1732851-open-text-color-ESR.patch

[Approval Request Comment]
User impact if declined: unreadable buttons on HCT when the button is open but not hovered.
Testing completed (on c-c, etc.): on c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9245010 [details] [diff] [review]
1732851-open-text-color-ESR.patch

[Triage Comment]
Approved for esr91

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/2408a3e26a23