Closed
Bug 1732906
Opened 3 years ago
Closed 3 years ago
browser_rules_eyedropper.js is failing with EFT enabled
Categories
(DevTools :: Inspector, task)
DevTools
Inspector
Tracking
(firefox95 fixed)
RESOLVED
FIXED
95 Branch
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: dt-perf-stability-mvp)
Attachments
(1 file)
A call to isXul while the eyedropper gets hidden is throwing, making the test fail.
|
Assignee | |
Comment 1•3 years ago
|
||
With EFT, tests using the eyedropper were failing because of the isXul check
done when the eyedropper gets hidden: the document.documentElement property
was null at this point and the isXul method was throwing.
This patch replace the isXul check with a check on the presence of an abortController
property, which we do now set in the show method.
Depends on D126807
|
|
Assignee | |
Updated•3 years ago
|
Whiteboard: dt-perf-stability-mvp
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f2419a8c8c5f [devtools] Refactor eyedropper show/hide methods. r=ochameau.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2648d026f172 [devtools] Refactor eyedropper show/hide methods. r=ochameau.
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(nchevobbe)
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•