1732906 - browser_rules_eyedropper.js is failing with EFT enabled

Status: RESOLVED FIXED

(DevTools :: Inspector, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

A call to isXul while the eyedropper gets hidden is throwing, making the test fail.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1732906 - [devtools] Refactor eyedropper show/hide methods. r=ochameau.

With EFT, tests using the eyedropper were failing because of the isXul check
done when the eyedropper gets hidden: the document.documentElement property
was null at this point and the isXul method was throwing.
This patch replace the isXul check with a check on the presence of an abortController
property, which we do now set in the show method.

Depends on D126807

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2419a8c8c5f
[devtools] Refactor eyedropper show/hide methods. r=ochameau.

Comment 3

[Cristian Tuns]

Backed out for causing mochitest failures.

• Backout link
• Push with failures
• Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2648d026f172
[devtools] Refactor eyedropper show/hide methods. r=ochameau.

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2648d026f172