Uploaded Addon issue “Installation aborted because the add-on appears to be corrupt”
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
People
(Reporter: palampri, Unassigned)
Details
Attachments
(1 file)
|
33.07 KB,
text/plain
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36 Edg/94.0.992.31
Steps to reproduce:
I have created a new experimental addon (https://addons.mozilla.org/en-US/firefox/addon/microsoft-power-automate-dev/ 1)
Addon has been reviewed and approved, although when I am trying to install it to firefox is says “Installation aborted because the add-on appears to be corrupt”
Is something that I need to fix or it is something with the firefox sign servers?
If I download it as .xpi and install it for debugging it works fine
|
||
Comment 2•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Layout' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
||
Comment 3•3 years ago
|
||
(Moving to a better component, might not be the perfect one yet...)
Palampri, thank you for the report. Could you tell us details about your build environment (OS, version, packaging tools incl version) the exact steps you did to package that file?
Thanks!
|
||
Comment 4•3 years ago
|
||
The path separators are incorrect. The zip file uses \ instead of /.
See this preview:
- note the
\as path separator: https://robwu.nl/crxviewer/?crx=https%3A%2F%2Faddons.mozilla.org%2Ffirefox%2Fdownloads%2Ffile%2F3843693%2Fmicrosoft_power_automate_dev-2.0.5-fx.xpi - For comparison, here is a xpi with the correct path separator: https://robwu.nl/crxviewer/?crx=https%3A%2F%2Faddons.mozilla.org%2Ffirefox%2Fdownloads%2Ffile%2F3809748%2Fhttps_everywhere-2021.7.13-an%2Bfx.xpi
You should update your packaging mechanism to use / instead of \.
Hello Rob,
we own the https://addons.mozilla.org/en-US/firefox/addon/power-automate-desktop/ which uploaded at Dec 11, 2020 and works fine
which has the \ as you can see here
Is there any possibility that the extension hasn't been signed correctly from firefox servers?
Sorry Andrea I didn't see your message :(
Build env
OS
Edition Windows 10 Enterprise
Version 21H1
OS build 19043.1237
Experience Windows Feature Experience Pack 120.2212.3530.0
Packing script
we are using a simple powershell script just to zip contents
$json = Get-Content '.\Firefox Extension\dist\manifest.json' | Out-String | ConvertFrom-Json
$loc = "builds"
Compress-Archive -Path '.\Firefox Extension\dist\*' -DestinationPath "$($loc)\firefox.$($json.version).DEV.zip"
|
|
||
Comment 7•3 years ago
|
||
(In reply to palampri from comment #5)
Hello Rob,
we own the https://addons.mozilla.org/en-US/firefox/addon/power-automate-desktop/ which uploaded at Dec 11, 2020 and works fine
which has the\as you can see here
This is not a link to the version. Click on the manifest.json file to see that the version is 2.0.5 of your add-on (i.e. the same as what I linked before). The file name at the end is only a hint, the actual version is identified by the numbers after downloads/file/<fileid>.
This is the last version from the "Power Automate Desktop", which has the correct slashes as you can see:
https://robwu.nl/crxviewer/?crx=https%3A%2F%2Faddons.mozilla.org%2Ffirefox%2Fdownloads%2Ffile%2F3692811%2Fmicrosoft_power_automate_desktop_preview-2.0.2-fx.xpi&qf=manifest.json
Is there any possibility that the extension hasn't been signed correctly from firefox servers?
All add-ons discussed in this bug appear to have been signed correctly. The installation error is due to the inability to load the localizations (_locales/<lang>/messages.json).
The issue here is not in Firefox or AMO (though it may be easier if AMO rejected invalid paths), but in your packaging method.
The invalid path separator appears to be a known issue: https://github.com/PowerShell/PowerShell/issues/2140
Try one of the methods listed there to package your add-on.
I uploaded the 2.0.6 which seems that / are used
It seems powershell Compress-Archive was the issue
I used the to https://robwu.nl/crxviewer/ v2.0.6 and paths are correct,
Do you know why have been disabled?
|
|
||
Comment 10•3 years ago
|
||
(In reply to palampri from comment #9)
I used the to https://robwu.nl/crxviewer/ v2.0.6 and paths are correct,
Do you know why have been disabled?
Check the developer mail associated with the add-on. The Dev version of the add-on has been disabled, because the self-hosted distribution mechanism should be used instead of a public listing. The rejection message includes a reference to a page that explains the rationale and links to documentation: https://blog.mozilla.org/addons/2018/02/28/discontinuing-support-for-beta-versions/
Description
•