1733039 - Selected node in remote iframe is not selected back after reload when Fission is enabled

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open a tab with data:text/html,<meta charset=utf8><iframe src="https://example.com"></iframe>
2. Right click on the "Example domain" and select "Inspect"
3. The <h1> node, inside the iframe, should be selected
4. Reload the page

Expected results

The <h1> node is selected again

Actual results

The <h1> node is not selected again

---

This is caused by the WalkerFront's findNodeFront method, which always use the top level walker to querySelector [1], where it should use the walker from the nodeFront at hand

[1] https://searchfox.org/mozilla-central/rev/8db61933e64b13c4a0ae456bcaccbd86a519ccc5/devtools/client/fronts/walker.js#410

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1733039 - [devtools] Fix walkerFront#findNodeFront method for EFT/Fission. r=ochameau.

The top-level target walker was used to find elements, where we should use the
walker front of the nodeFront we have at hand.
The function was also checking if the node we're searching was associated with
this walker, which, with EFT, won't be the case as soon as we have to go through
an iframe.

Depends on D126808

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

pretty harmless, S3

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf18a96d849f
[devtools] Fix walkerFront#findNodeFront method for EFT/Fission. r=ochameau.

Comment 4

[Cristian Tuns]

Backed out for causing mochitest failures.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d7ded347278
[devtools] Fix walkerFront#findNodeFront method for EFT/Fission. r=ochameau.

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3d7ded347278