1733139 - [wpt-sync] Sync PR 30915 - [SelectMenu] Ensure that controller code correctly handles slot changes.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 30915 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30915
Details from upstream follow.

Ionel Popescu <[e-mail]> wrote:

[SelectMenu] Ensure that controller code correctly handles slot changes.

This CL extends HTMLSelectMenuElement::SelectMutationCallback to ensure
that controller code is correctly applied when the slot attribute is
changed.

With this change, \<slot> replacement is going to also clear the
initial provided parts, even if no valid part is provided yet.

Bug: 1234899
Change-Id: I98aec03f544a0fb73f2dc9aafdcac7c4e61e2aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175142
Reviewed-by: Dan Clark \<[e-mail]>
Reviewed-by: Mason Freed \<[e-mail]>
Commit-Queue: Ionel Popescu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#924586}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 30915 applied with additional changes from upstream: e333c696fe2013bac443ea8a9b5a9e2903f70dff, ef7d96d1f28fc098ffe92a18564a7e77f5d0eb42

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=67692efc80643771ef4193c5f8e68babe77e64f1

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 2
FAIL : 13

Chrome

OK : 2
PASS : 12
FAIL : 1

Safari

OK : 1
FAIL : 9
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/forms/the-selectmenu-element/selectmenu-parts-structure.tentative.html
To receive option part controller code, an element labeled as an option must be a descendant of the listbox part in a flat tree traversal: FAIL (Chrome: PASS, Safari: FAIL)
To receive button part controller code, an element labeled as a button must not be a descendant of the listbox part in a flat tree traversal: FAIL (Chrome: PASS, Safari: FAIL)
To receive listbox part controller code, an element labeled as a listbox must not be a descendant of the button part in a flat tree traversal: FAIL (Chrome: PASS, Safari: FAIL)
Button controller code should be applied in flat tree traversal order regardless of dynamic insertion order: FAIL (Chrome: PASS, Safari: FAIL)
Listbox controller code should be applied in flat tree traversal order regardless of dynamic insertion order: FAIL (Chrome: PASS, Safari: FAIL)
selected-value controller code should be applied in flat tree traversal order regardless of dynamic insertion order: FAIL (Chrome: PASS, Safari: FAIL)
Ensure that option controller code is updated when listbox changes: FAIL (Chrome: FAIL, Safari: FAIL)
Ensure that controller code is applied after updating the slot attribute: FAIL (Chrome: PASS, Safari: FAIL)
Ensure that controller code is applied when slot and part attributes are different: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative.html
Opening the popup and clicking an option should change the selectmenu's value: FAIL (Chrome: PASS)
With custom button and popup: opening the popup and clicking an option should change the selectmenu's value: FAIL (Chrome: PASS)
Clicking a popup with no listbox part does nothing: FAIL (Chrome: PASS)
Clicking a popup with a listbox that was removed does nothing: FAIL (Chrome: PASS)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6abda4017dab
[wpt PR 30915] - [SelectMenu] Ensure that controller code correctly handles slot changes., a=testonly
https://hg.mozilla.org/integration/autoland/rev/7fb122892c10
[wpt PR 30915] - Update wpt metadata, a=testonly

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6abda4017dab
https://hg.mozilla.org/mozilla-central/rev/7fb122892c10