Closed Bug 1733143 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 30938 - Fix webtransport/constructor.any.js

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox95 fixed)

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30938 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30938
Details from upstream follow.

Yutaka Hirano <yhirano@chromium.org> wrote:

Fix webtransport/constructor.any.js

WebTransport should throw a WebTransportError, not TypeError, when the
port is disallowed.

Bug: 1011392

Change-Id: Id5add9567a8fd21ad3bc31fec9fd60f6393c8524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180620
Commit-Queue: Yutaka Hirano \<yhirano@chromium.org>
Reviewed-by: Nidhi Jaju \<nidhijaju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#924636}

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 9 subtests

Status Summary

Firefox

OK : 4
FAIL : 36

Chrome

OK : 4
PASS : 32
FAIL : 4

Safari

OK : 3
FAIL : 27
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webtransport/constructor.any.serviceworker.html
WebTransport constructor should reject URL 'null': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL '': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'no-scheme': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'http://example.com/': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'quic-transport://example.com/': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'https:///': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'https://example.com/#failing': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'https://web-platform.test:999999/': FAIL (Chrome: PASS, Safari: FAIL)
Connection to port 0 should fail: FAIL (Chrome: FAIL, Safari: FAIL)
/webtransport/constructor.any.worker.html
WebTransport constructor should reject URL 'null': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL '': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'no-scheme': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'http://example.com/': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'quic-transport://example.com/': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'https:///': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'https://example.com/#failing': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'https://web-platform.test:999999/': FAIL (Chrome: PASS, Safari: FAIL)
Connection to port 0 should fail: FAIL (Chrome: FAIL, Safari: FAIL)
/webtransport/constructor.any.html
WebTransport constructor should reject URL 'null': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL '': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'no-scheme': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'http://example.com/': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'quic-transport://example.com/': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'https:///': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'https://example.com/#failing': FAIL (Chrome: PASS, Safari: FAIL)
WebTransport constructor should reject URL 'https://web-platform.test:999999/': FAIL (Chrome: PASS, Safari: FAIL)
Connection to port 0 should fail: FAIL (Chrome: FAIL, Safari: FAIL)
/webtransport/constructor.any.sharedworker.html
WebTransport constructor should reject URL 'null': FAIL (Chrome: PASS)
WebTransport constructor should reject URL '': FAIL (Chrome: PASS)
WebTransport constructor should reject URL 'no-scheme': FAIL (Chrome: PASS)
WebTransport constructor should reject URL 'http://example.com/': FAIL (Chrome: PASS)
WebTransport constructor should reject URL 'quic-transport://example.com/': FAIL (Chrome: PASS)
WebTransport constructor should reject URL 'https:///': FAIL (Chrome: PASS)
WebTransport constructor should reject URL 'https://example.com/#failing': FAIL (Chrome: PASS)
WebTransport constructor should reject URL 'https://web-platform.test:999999/': FAIL (Chrome: PASS)
Connection to port 0 should fail: FAIL (Chrome: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4be12a96b71c [wpt PR 30938] - Fix webtransport/constructor.any.js, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4be12a96b71c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.