Closed Bug 1733145 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30937 - Fix the transform-fixed-bg-*.html tests.

Categories

(Core :: Web Painting, task, P4)

Product:
Core
Component:
Web Painting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30937 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30937
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Fix the transform-fixed-bg-*.html tests.

These tests were, I believe, testing an old version of the spec, prior
to the wording:

Fixed backgrounds on the root element are affected by any transform
specified for that element. For all other elements that are effected
by a transform (i.e. have a transform applied to them, or to any of
their ancestor elements), a value of fixed for the
background-attachment property is treated as if it had a value of
scroll.

This updates the tests to reflect that change.

I intend to write an additional set of tests testing fixed backgrounds
on the root element, which these did not test.

Prior to this change:

  • Chromium and WebKit pass tests 005 and 007 only and fail the other 5
    tests (but fail 002 and 004 differently).
  • Gecko fails all 7 tests

After this change:

  • Chromium and WebKit pass tests 001 and 003 only, and fail the other 5
    tests (but fail 002 and 004 differently).
  • Gecko passes all 7 tests.

I checked in both Chromium and Gecko that all 7 tests match the
reference if I remove the background-attachment: fixed.

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests

Status Summary

Firefox

PASS: 3
FAIL: 4

Chrome

PASS: 1
FAIL: 6

Safari

PASS: 2
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-transforms/transform-fixed-bg-003.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-transforms/transform-fixed-bg-004.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-transforms/transform-fixed-bg-006.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-transforms/transform-fixed-bg-007.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dbd0bdc567e
[wpt PR 30937] - Fix the transform-fixed-bg-*.html tests., a=testonly
https://hg.mozilla.org/integration/autoland/rev/13a9d9e00451
[wpt PR 30937] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1dbd0bdc567e
https://hg.mozilla.org/mozilla-central/rev/13a9d9e00451

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.