Closed Bug 1733147 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30922 - Let highlight styles be nullptr by default

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30922 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30922
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

Let highlight styles be nullptr by default

We currently create a set of highlight ComputedStyle objects during
the creation of StyleHighlightData, and create such a data object
during CreateInitialStyleSingleton. This is not quite the right
thing to do, because we don't pick up initial data from
InitialStyleForElement. It also creates unnecessary noise from
PkStyleHighlightData plus the functions that accept it.

Bug: 1024156
Change-Id: I920ab636c5593885962121e2f6c30a05e7c1c2a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172629
Commit-Queue: Anders Hartvoll Ruud \<andruud@chromium.org>
Reviewed-by: Delan Azabani \<dazabani@igalia.com>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#924750}

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/highlight-cascade-004.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb8b2db3c78d
[wpt PR 30922] - Let highlight styles be nullptr by default, a=testonly

https://hg.mozilla.org/mozilla-central/rev/fb8b2db3c78d

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.