Closed Bug 1733176 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30953 - Fixing serialization of grid-auto-flow

Categories

(Core :: DOM: CSS Object Model, task, P4)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30953 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30953
Details from upstream follow.

Ana SollanoKim <ansollan@microsoft.com> wrote:

Fixing serialization of grid-auto-flow

This CL fixes a serialization of grid-auto-flow issue where the word
'row' was being included even though it isn't necessary. The tests
grid-auto-flow-computed.html and grid-auto-flow-valid.html are fixed,
while the expectations of wpt and fast tests are updated or modified to
add new passes.

Bug: 1156390
Change-Id: If91100c3eff7b6cd4caf349114afb0fec71e9e98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179598
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Commit-Queue: Ana Sollano Kim \<ansollan@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#925295}

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 14 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
PASS : 14

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)

Tests Disabled in Gecko Infrastructure

/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28bd3074279a
[wpt PR 30953] - Fixing serialization of grid-auto-flow, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.