Closed Bug 1733205 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30952 - Highlight API: Add test to check for repaint after CSS rule change

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30952 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30952
Details from upstream follow.

Dan Clark <daniec@microsoft.com> wrote:

Highlight API: Add test to check for repaint after CSS rule change

Add a test validating that a Highlight range is repainted if the
corresponding ::highlight CSS rule changes. Currently this works
correctly because changing the CSS causes ValidateHighlightMarkers
to remove and re-add all ranges to the DocumentMarkerController,
triggering a repaint. But, an optimization to ValidateHighlightMarkers
to eliminate this extra work could cause the repaint to be skipped.

So, adding a test to ensure that we don't regress this scenario.

Bug: 1251193
Change-Id: I12936364eb057db6c684df4b45703e5bd9cb5cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182785
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Commit-Queue: Dan Clark \<daniec@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#925798}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

TIMEOUT: 1

Chrome

FAIL : 1

Safari

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-highlight-api/painting/custom-highlight-painting-invalidation-007.html: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43ca30c2ca64
[wpt PR 30952] - Highlight API: Add test to check for repaint after CSS rule change, a=testonly
https://hg.mozilla.org/integration/autoland/rev/55ee031b4b8e
[wpt PR 30952] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/43ca30c2ca64
https://hg.mozilla.org/mozilla-central/rev/55ee031b4b8e

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.