1733238 - Fire ANIMATED state change events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task, P3)

Description

[Eitan Isaacson [:eeejay]]

If an image's source changes to/from an animated gif we need to fire an ANIMATED state change. I don't know if listening for a src attribute change is enough here since it might still need to load the image to know if it is animated. A better indicator is nsAccessibilityService::NotifyOfImageSizeAvailable, but we will need to store the previous state for that.

Comment 1

[Eitan Isaacson [:eeejay]]

Changing severity to S3 because this is ongoing cache the world work that does not affect current users.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733238 - P1: Add test for late-loading image and INVISIBLE change. r=Jamie

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733238 - P2: Make ImageAccessible an imgINotificationObserver. r=Jamie

Use imgINotificationObserver to get notified of size availability.
Layout uses an observer to wait for this too. Our observer is notified
after layout so we should have bounds by then.

We need to store the request status because we get a lot of "replayed"
status changes that would cause chatty and wrong state change events
when the accessible is first created and bound to parent.

We can use that status for both INVISIBLE and ANIMATED states in
NativeState.

Depends on D127718

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733238 - P3: Add ANIMATED state change notification to ImageAccessible. r=Jamie

Depends on D127719

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c132ebfabb2
P1: Add test for late-loading image and INVISIBLE change. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/352c6a7ae5cd
P2: Make ImageAccessible an imgINotificationObserver. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/7753b03a092a
P3: Add ANIMATED state change notification to ImageAccessible. r=Jamie

Comment 6

[Cristian Tuns]

Backed out for causing hybrid build bustages

• Backout link
• Push with failures
• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5d218eb6acb
P1: Add test for late-loading image and INVISIBLE change. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/910aebecda65
P2: Make ImageAccessible an imgINotificationObserver. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/af8436178a49
P3: Add ANIMATED state change notification to ImageAccessible. r=Jamie

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for Bp-hybrid bustages on ImageAccessible

Backout link: https://hg.mozilla.org/integration/autoland/rev/acc023ae7f611c778481eb6bce33c2f319e9fc10
Log link: https://treeherder.mozilla.org/logviewer?job_id=354415748&repo=autoland&lineNumber=84327

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30572d7dd9dd
P1: Add test for late-loading image and INVISIBLE change. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/0133dadaf3eb
P2: Make ImageAccessible an imgINotificationObserver. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/10f92eac8bc7
P3: Add ANIMATED state change notification to ImageAccessible. r=Jamie

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/30572d7dd9dd
https://hg.mozilla.org/mozilla-central/rev/0133dadaf3eb
https://hg.mozilla.org/mozilla-central/rev/10f92eac8bc7