1733243 - Fire MULTISELECTABLE/EXTSELECTABLE state change events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task, P3)

Description

[Eitan Isaacson [:eeejay]]

We need to add aria-multiselectable to LocalAccessible::AttributeChangesState and multiple to HTMLSelectListAccessible::AttributeChangesState.

Comment 1

[Eitan Isaacson [:eeejay]]

Changing severity to S3 because this is ongoing cache the world work that does not affect current users.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733243 - P1: Don't recreate aria-multiselectable changes, fire state change instead. r?morgan

We were force recreating accessibles when their aria-multiselectable
attribute changed. This was perhaps done in the past because of
percieved limitations in COM, or the implementing class was different.

This isn't the case anymore. We should instead fire state change events
when aria-multiselectable changes.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733243 - P2: Recreate accessible when select size or multiple changes. r?morgan

If a <select> element with a default size or size of 1 gets the
multiple attribute it will change from a combobox button to an
embedded listbox. Similarly, if a select's size is set to something
larger than 1 it will convert from a combobox button to a listbox.

We should recreate the select's subtree because the
implementing classes are different for those two cases.

Depends on D128275

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1733243 - P3: Fire state change events for select[multiple]. r?morgan

If a select's size is greater than 1 it won't be recreated when multiple
is added or removed. State change events should be fired in that case.

Depends on D128276

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/256ac233fc22
P1: Don't recreate aria-multiselectable changes, fire state change instead. r=morgan
https://hg.mozilla.org/integration/autoland/rev/8db3140db184
P2: Recreate accessible when select size or multiple changes. r=morgan
https://hg.mozilla.org/integration/autoland/rev/2355494e86d0
P3: Fire state change events for select[multiple]. r=morgan

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/256ac233fc22
https://hg.mozilla.org/mozilla-central/rev/8db3140db184
https://hg.mozilla.org/mozilla-central/rev/2355494e86d0