"Page.lifecycleEvent" should only be emitted for top-level documents
Categories
(Remote Protocol :: CDP, defect, P3)
Tracking
(Not tracked)
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
As given by the CDP documentation the Page.lifecycleEvent should only be emitted for top-level documents. Right now we do it also for each and every frame.
emitLifecycleEvent() is called in _onFrameAttached() and handleEvent().
|
Assignee | |
Comment 1•3 years ago
|
||
Going to work on that given it makes it easier for me to enable Fission for CDP browser-chrome tests over on bug 1601245.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Hm, the documentation might actually be wrong. When I check the log output from Chrome as given on bug 1601245 comment 25 I can clearly see these events also being sent out for sub frames. As such I filed https://bugs.chromium.org/p/chromium/issues/detail?id=1254621 to get this clarified and fixed.
For now I'm assuming that it is an issue with the documentation and that events have to be sent out for all kinds of browsing contexts.
|
|
Assignee | |
Comment 3•3 years ago
|
||
Closing out this bug given that it looks like a documentation error and we should better follow the actual behavior of Chrome.
Description
•