Closed Bug 1733268 Opened 3 years ago Closed 2 years ago

Cache OPAQUE1 state (no state change event)

Categories

(Core :: Disability Access APIs, task, P2)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: eeejay, Assigned: morgan)

References

Details

(Whiteboard: [ctw-m1])

Attachments

(1 file)

I think it is mostly Android that cares about this.

This is hard to do because this state is style-derived.

Changing severity to S3 because this is ongoing cache the world work that does not affect current users.

Severity: -- → S3
Type: defect → task
Priority: -- → P3
Blocks: 1757812
Priority: P3 → P2
Whiteboard: [ctw-m1]
Assignee: nobody → mreschenberg

:Jamie is this still an M1 deliverable?

Flags: needinfo?(jteh)

Pasting from a convo what I think we should do here. I don't think we should fire state change events for OPAQUE1 changes. Instead quietly caching opacity is a better idea.

i think we need opacity cached in the remote with a common method like double Accessible::Opacity(), that method could be used in the remote case to calculate OPAQUE1 state. i got more androidy things to do so if either of you wants to dig in, go ahead. not worries if not. i can loop back to this.

Yes, it's m1 because it's needed by Android.

We should be able to use the new style change stuff to manage this. We can include it in CacheDomain::Style.

Flags: needinfo?(jteh)
Summary: Fire OPAQUE1 state change events → Cache OPAQUE1 state (no state change event)
Blocks: 1758540
Attachment #9267479 - Attachment description: WIP: Bug 1733268: Cache states::OPAQUE1, update state on style change r?Jamie,eeejay → Bug 1733268: Cache states::OPAQUE1, update state on style change r?Jamie,eeejay
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da82675f86d7
Cache states::OPAQUE1, update state on style change r=eeejay
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Blocks: 1765217
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: