Closed Bug 1733352 Opened 2 years ago Closed 1 year ago

Move IcuLocale calls from SpiderMonkey into the unified Intl API

Categories

(Core :: Internationalization, task)

Product:
Core
Component:
Internationalization
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox94 --- wontfix
firefox95 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

(Whiteboard: [i18n-unification] )

Attachments

(2 files)

Bug 1733352 - Part 1: Fix IcuLocale to test exactly for the string "und". r=#platform-i18n-reviewers!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1733352 - Part 2: Move IcuLocale calls from SpiderMonkey to mozilla::intl. r=#platform-i18n-reviewers!
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

Inputs like IcuLocale("undef") were also incorrectly changed to "".

Changing the strncmp() call to strcmp() would have fixed this issue, but
because the code was explicitly written to avoid calling strcmp(), we instead
have to compare each individual character.

Depends on D127095

Whiteboard: [i18n-unification]
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3d3c2aa58ba0
Part 1: Fix IcuLocale to test exactly for the string "und". r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/966beb03b36c
Part 2: Move IcuLocale calls from SpiderMonkey to mozilla::intl. r=platform-i18n-reviewers,gregtatum

https://hg.mozilla.org/mozilla-central/rev/3d3c2aa58ba0
https://hg.mozilla.org/mozilla-central/rev/966beb03b36c

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.