1733352 - Move IcuLocale calls from SpiderMonkey into the unified Intl API

Status: RESOLVED FIXED

(Core :: Internationalization, task)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1733352 - Part 1: Fix IcuLocale to test exactly for the string "und". r=#platform-i18n-reviewers!

Inputs like IcuLocale("undef") were also incorrectly changed to "".

Changing the strncmp() call to strcmp() would have fixed this issue, but
because the code was explicitly written to avoid calling strcmp(), we instead
have to compare each individual character.

Depends on D127095

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1733352 - Part 2: Move IcuLocale calls from SpiderMonkey to mozilla::intl. r=#platform-i18n-reviewers!

Depends on D127096

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d3c2aa58ba0
Part 1: Fix IcuLocale to test exactly for the string "und". r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/966beb03b36c
Part 2: Move IcuLocale calls from SpiderMonkey to mozilla::intl. r=platform-i18n-reviewers,gregtatum

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3d3c2aa58ba0
https://hg.mozilla.org/mozilla-central/rev/966beb03b36c