1733421 - Browser Toolbox doesn't jump to element in tree on in-content pages

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Richard Marti (:Paenglab)]

Bug 1732966 fixed the issue that the Browser Toolbox doesn't highlight elements in in-content pages like the prefs.

But now it doesn't jump to the element in the tree. The rules view shows the correct rules.

On normal web pages all is working correctly.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Do you have a test case Richard? I quickly checked on Nightly and everything seems fine

Comment 2

[Richard Marti (:Paenglab)]

STR:

• Open Browser Toolbox
• Open the Settings
• Click in Browser Toolbox the pick an element button and click on an element in the Settings like a checkbox

Result: On the right of the Browser Toolbox in Rules the rules for checkbox are shown but on the left the tree doesn't jump to the element. Below the breadcrumbs shows the correct path.

Comment 3

[Richard Marti (:Paenglab)]

I meant the FX settings not the Browser Toolbox settings.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Ah yes, thanks, I'm looking into this

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1733421 - [devtools] Fix BrowserToolbox node picker. r=ochameau.

This patch sort of reverts to what existed before Bug 1731996, except
that we still handle hovering on iframe padding.

The "refactoring" that was done in Bug 1731996 made the Browser Toolbox nodePicker
misbehaving.
Unfortunately, it's hard to have a test for the Browser Toolbox nodePicker, as
when we use BrowserTestUtils.synthesizeMouse we explicitely pass the window
we want the event to happen in so we don't hit any of the propagation stopper
that might occur when using it manually.

Depends on D127224

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60c5ef76eb44
[devtools] Fix BrowserToolbox node picker. r=ochameau.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/60c5ef76eb44

Comment 9

[Julian Descottes [:jdescottes]]

Should we ask for an uplift?

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Julian Descottes [:jdescottes] from comment #9)

Should we ask for an uplift?

Yes, that would be better I guess

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9244342 [details]
Bug 1733421 - [devtools] Fix BrowserToolbox node picker. r=ochameau.

Beta/Release Uplift Approval Request

• User impact if declined: Using the Browser Toolbox , the node picker won't work properly on pages like about:preferences, or for inspecting chrome documents (e.g. devtools panels)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. In Firefox, open DevTools inspector on a page of your choice

1. Open the MultiProcess Browser Toolbox
2. Select the node picker
3. Try to select an element in the inspector markup view

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): DevTools/Browser Toolbox fix only, only impacting node picker behavior, which is not something regular users are using
• String changes made/needed:

Comment 12

[Ciprian Georgiu, Desktop QA]

Reproduced this bug on an affected Nightly (2021-09-30), using STR from comment 2.

The issue is verified as fixed on latest Nightly 95.0a1, under macOS 11, Win 10 x64 and Ubuntu 18.04 x64.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244342 [details]
Bug 1733421 - [devtools] Fix BrowserToolbox node picker. r=ochameau.

Fixes a new regression before it ships in 94. Approved for 94.0b8.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/81c6f25abeaa

Comment 15

[Ciprian Georgiu, Desktop QA]

The issue is also verified as fixed on Beta 94.0b8, under macOS 11, Win 11 x64 and Ubuntu 18.04 x64.