1733425 - SessionStore.getClosedTabData should always return an object

Status: RESOLVED FIXED

(Firefox :: Session Restore, task)

Description

[Mark Banner (:standard8)]

SessionStore.getClosedTabData is only called in production code with the aAsString argument as false.

In test code, the majority of tests call JSON.parse to translate the string back into an object.

We can therefore drop the string option, and have it always return an object. Note this is split out from bug 1505572.

For running tests (after building), you'll want to do ./mach mochitest path/to/test.

I'm happy to mentor this. For instructions on how to get your local build of Firefox up and running and submit your patch, see https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Note this bug will be auto-assigned when the first patch is attached.

Comment 1

[Claudia Batista [:claubatista]]

Attachment: Bug 1733425 - Change SessionStore.getClosedTabData to always return an object insteaf of a string. r=standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e370b1861c12
Change SessionStore.getClosedTabData to always return an object insteaf of a string. r=Standard8,extension-reviewers,zombie

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e370b1861c12