1733426 - Permanent Windows browser_parsable_css.js | Got error message for autocomplete-item.css: Expected color but found �color-mix�. Error in parsing value for �background-color�. Declaration dropped. - when Gecko 94 merges to Beta on 2021-10-04

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log

TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for jar:file:///Z:/task_1633008422/build/application/firefox/browser/features/[e-mail]!/chrome/content/skin/autocomplete-item.css: Expected color but found color-mix. Error in parsing value for background-color. Declaration dropped. -
TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | All the styles (239) loaded without errors. - Got 1, expected +0 

Comment 1

[Tim Giles [:tgiles]]

Hey :aryx, this is the first time I've encountered a situation like this. Do I just follow the instructions in "TRUNK AS EARLY BETA", i.e. make my fix and then test against the simulation by running ./mach try release -v 94.0b1 --tasks release-sim --migration central-to-beta? Or do I need to get access and open the simulation doc based on the instructions under "Beta Simulations"? Sorry for the dumb questions, but I'm a bit lost.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please run

1. ./mach try release -v 94.0b1 --tasks release-sim --migration central-to-beta --no-push
2. hg commit -m "Early Beta config"
3. ./mach try chooser --full --artifact browser/base/content or similar.

In the end, color-mix cannot be used because it's only enabled on Nightly.

Comment 3

[Tim Giles [:tgiles]]

I'll add a workaround for this, but I also need to determine where this stylesheet is being loaded from since it should be a resource/chrome stylesheet and have access to color-mix.

Comment 4

[Tim Giles [:tgiles]]

After setting up the early beta config, I went through Try chooser but it looks like the tree is closed right now

remote: ************************** ERROR ****************************
remote: Error accessing https://treestatus.mozilla-releng.net/trees/try :
remote: <urlopen error EOF occurred in violation of protocol (_ssl.c:877)>
remote: Unable to check if the tree is open - treating as if CLOSED.
remote: To push regardless, include "CLOSED TREE" in your push comment.
remote: *************************************************************
remote:
remote:
remote: transaction abort!
remote: rollback completed
To hg::ssh://hg.mozilla.org/try
 ! [remote rejected]           HEAD -> branches/default/tip (nothing changed on remote)
error: failed to push some refs to 'hg::ssh://hg.mozilla.org/try'

I'll try again tomorrow and see what happens.

Comment 5

[Tim Giles [:tgiles]]

Attachment: Bug 1733426: Add workaround in test due to autocomplete-item.css being treated as a non-privileged stylesheet. r?dimi

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Dimi, the test fixed the reported the issue. Can you get it reviewed and landed?

Comment 7

[Dimi Lee [:dimi]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #6)

Dimi, the test fixed the reported the issue. Can you get it reviewed and landed?

ah, sorry for the late reply, I missed the needinfo somehow.
I'm not sure what the current status of this patch is, so not sure what the next step is to proceed.
I think :tim had discussed with :sfoster before taking PTO. I'll redirect the needinfo to sam because I believe sam has more context on this bug.

Comment 8

[Sam Foster [:sfoster] (he/him)]

Thanks Dimi,
I can commandeer the revision and get this landed.

:aryx, is there a way I can verify this patch locally? I just built beta and ran the test without the patch and it passed. Is there something I need in my mozconfig to ensure I'm testing correctly?

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Code sheriffs imported the patch and it resolved the issue.

I never compile a central-as-beta build locally, only 'built' artifact builds for Linux opt. Beta + Windows only builds PGO optimized ("shippable") builds. You can follow the central-as-beta instructions with the mentioned --no-push, commit the changes and then build. Or do that config change, add the Windows opt build to yesterday's central-as-beta simulation and use that for your artifact build.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9e17809e82d
Add workaround in test due to autocomplete-item.css being treated as a non-privileged stylesheet. r=dimi

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b9e17809e82d

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This caused an unused whitelist entry on Linux and macOS, patch incoming.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1733426 - restrict exception for autocomplete-item.css in browser_parsable_css.js to Windows. r=tgiles

The exception got added in this bug, the usage of the CSS rule in bug 1696132
which started the Windows-only failures.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a65c213438c
restrict exception for autocomplete-item.css in browser_parsable_css.js to Windows. r=tgiles

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1a65c213438c

Comment 16

[Intermittent Failures Robot]

15 failures in 551 pushes (0.027 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-beta: 15

Platform and build breakdown:

• windows7-32-shippable-qr: 2
  • opt: 2
• windows10-64-2004-shippable-qr: 12
  • opt: 12
• windows10-64-2004-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1733426&startday=2021-10-08&endday=2021-10-08&tree=all

Comment 17

[Marian-Vasile Laza]

Verified in today's central-as-beta simulation.

Comment 18

[Intermittent Failures Robot]

37 failures in 3626 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #32 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-beta: 37

Platform and build breakdown:

• windows10-64-2004-shippable-qr: 27
  • opt: 27
• windows10-64-2004-devedition-qr: 4
  • opt: 4
• windows7-32-shippable-qr: 6
  • opt: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1733426&startday=2021-10-04&endday=2021-10-10&tree=all

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3b9abf29f936