Closed Bug 1733454 Opened 2 months ago Closed 2 months ago

Ensure we use the same default parameters with --diff

Categories

(Firefox Build System :: Task Configuration, defect)

defect

Tracking

(firefox94 fixed)

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(2 files)

When we don't specify --parameters we use the default values. Only when --diff mode was enabled, these default values were being calculated once per revision which results in differing parameters and diffs in the graph.

Instead, we should only compute default params once, and then re-use them for both taskgraph generations.

Previously we were defaulting the parameters option to '[None]'. This caused
the generator to re-compute the default values across revisions in --diff mode,
resulting in different parameters being used and a different resulting
taskgraph.

By instantiating the parameters up front in this case, we can ensure that the
same parameter set is being used across both revisions.

Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95af8be0a5b8
Make sure we re-use the same default parameters in --diff mode, r=taskgraph-reviewers,aki

Previously we were defaulting the parameters option to '[None]'. This caused
the generator to re-compute the default values across revisions in --diff mode,
resulting in different parameters being used and a different resulting
taskgraph.

By instantiating the parameters up front in this case, we can ensure that the
same parameter set is being used across both revisions.

This is a sync of the changes that have already landed in mozilla-central.

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/ci/taskgraph/rev/9d274b8fa7d5
[gecko sync] Make sure we re-use the same default parameters in --diff mode, r=aki
You need to log in before you can comment on or make changes to this bug.