Replace OS.File with IOUtils in TelemetryControllerParent.jsm
Categories
(Toolkit :: Telemetry, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: standard8, Assigned: ash110, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
Using OS.File for file access is now obsolete and can be replaced by code using IOUtils. Working towards this,TelemetryControllerParent.jsm is loaded on startup and accesses OS.File. Fixing this should help a little towards startup performance.
The code in question can be found here.
There is background information here about how to migrate from OS.File to IOUtils. If you have questions, please ask.
To run the tests after you've built, you can run ./mach xpcshell-test toolkit/components/telemetry/. You should also check ESLint before commiting: ./mach eslint toolkit/components/telemetry/.
I'm happy to mentor this. Note this bug will be auto-assigned when the first patch is attached.
|
Assignee | |
Comment 1•3 years ago
|
||
Migrated OS.File.read to IOUtils.readUTF8, toolkit/components/telemetry/app/TelemetryControllerParent.jsm:1347. Removed OS from imports.
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a7389a86ec78 Replace OS.File usage with IOUtils in TelemetryControllerParent.jsm. r=Standard8
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
|
Reporter | |
Comment 4•3 years ago
|
||
Thank you for working on this Ashwin.
|
|
Assignee | |
Comment 5•3 years ago
|
||
Glad to help, hoping to be more active here
Description
•