Closed
Bug 1733557
Opened 3 years ago
Closed 3 years ago
Thrown errors in the SourceTree component do not bubble up to the AppErrorBoundaryComponent
Categories
(DevTools :: Debugger, enhancement)
DevTools
Debugger
Tracking
(firefox94 fixed)
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: bomsy, Assigned: bomsy)
Details
Attachments
(1 file)
This is due to the parent PrimaryPanesComponent catches the errors here https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/components/PrimaryPanes/index.js#36
This is no longer needed since we now have the AppErrorBoundaryComponent and should be removed so errors bubble up.
|
Assignee | |
Comment 1•3 years ago
|
||
This removes the componentDidCatch in the PriamryPanes Component which swallows errors
of its child components.
As we have the AppErrorBoundary Component now, all debbuger errors show bubble all the way up.
|
||
Updated•3 years ago
|
Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•3 years ago
|
Summary: Thrown errors in the SourceTree component does not bubble up to the AppErrorBoundaryComponent → Thrown errors in the SourceTree component do not bubble up to the AppErrorBoundaryComponent
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88ef32c564e6 [devtools] Remove componentDidCatch in PrimaryPanesComponent r=nchevobbe
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•