Closed Bug 1733612 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31057 - [css-pseudo] Support dynamic changes on highlight pseudos

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31057 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31057
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:

[css-pseudo] Support dynamic changes on highlight pseudos

Take into account changes on highlight pseudos (::target-text,
::spelling-error and ::grammar-error) in order to
compute StyleDifference in LayoutObject::SetStyle().

002 tests fail due to a problem that is being fixed in CL:3197850.
Apart from that target-text tests fail due to a repainting issue
(see https://crbug.com/1179938).

BUG=1035708,1251193
TEST=external/wpt/css/css-pseudo/target-text-dynamic-00*.html
TEST=wpt_internal/css/css-pseudo/grammar-error-color-dynamic-00*.html
TEST=wpt_internal/css/css-pseudo/spelling-error-color-dynamic-00*.html

Change-Id: I83ab02ab1225df86fbb9251eb0954409c17f9843

Reviewed-on: https://chromium-review.googlesource.com/3177663
WPT-Export-Revision: b1e580908eaa2eb9b9a99e0732f4b987b488b690

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

TIMEOUT: 4

Chrome

FAIL : 4

Safari

PASS : 1
FAIL : 2
TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/target-text-dynamic-001.html: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/css/css-pseudo/target-text-dynamic-002.html: TIMEOUT (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/target-text-dynamic-003.html: TIMEOUT (Chrome: FAIL, Safari: PASS)
/css/css-pseudo/target-text-dynamic-004.html: TIMEOUT (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/784cf7ba18d6
[wpt PR 31057] - [css-pseudo] Support dynamic changes on highlight pseudos, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7c783dfa3499
[wpt PR 31057] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.