1733675 - Fixes for newtab Pocket section experiment based on some design feedback

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Scott [:thecount] Downe]

• Update health topic label to health and fitness
• Update privacy notice at bottom of page to no longer link to the anchor of the privacy link, but instead the whole link.
• In card stp button icon alignment and size fixes.
• New meatball menu still has an archive to Pocket button. Does this still make sense?

Comment 1

[Scott [:thecount] Downe]

Also I noticed the new footer menu has some border issues where on some screens the borders don't overlap quite like I expected them to.

I think I need a heavier solution for them.

Comment 2

[Scott [:thecount] Downe]

• Make sure we see a bookmarked message in compact with stp button, and update its colour to be slightly lighter.

Comment 3

[Scott [:thecount] Downe]

Attachment: Bug 1733675 - Fixes some nits in Pocket newtab experiment.

Comment 4

[Scott [:thecount] Downe]

To test:

Generic changes:

1. Set browser.newtabpage.activity-stream.discoverystream.compactLayout.enabled to true
2. Set browser.newtabpage.activity-stream.discoverystream.newFooterSection.enabled to true
3. Set browser.newtabpage.activity-stream.discoverystream.saveToPocketCard.enabled to true
4. Open a new tab.
5. Health topic in topics section should now be health & fitness to better match the target page. This change should persist in all configurations.
6. Privacy link should now be linking to https://www.mozilla.org/en-US/privacy/firefox/ dropping the "#suggest-relevant-content"
7. The save to pocket button while hovering over a card should have a slightly smaller icon.
8. new topics section should have clean and matching borders on top and bottom of topics in all media queries.
9. Turn off all the values in steps 1-3 and check nothing is different for steps6-8.

The new menu items:

1. Set browser.newtabpage.activity-stream.discoverystream.saveToPocketCard.enabled to true
2. Open the meatball menu.
3. EXPECTED: Should see only bookmark above the line break.
4. Click the save to Pocket button.
5. Open the meatball menu
6. EXPECTED: Should see "bookmark, archive, delete" above the line break.
7. EXPECTED: Clicking bookmark should update meantball menu item to remove bookmark.
8. EXPECTED: Archive/delete should work as expected.

The new message footer, this is the message displayed at the bottom of a card if you save to pocket or bookmark:

1. Set browser.newtabpage.activity-stream.discoverystream.compactLayout.enabled to true
2. Open a new tab
3. Click save to pocket from meatball menu in 1 card.
4. Click bookmark from the meatball menu in another card.
5. EXPECTED: Should be slightly smaller than before bookmark/savetopocket messages than before.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e3c0cf197a3
Fixes some nits in Pocket newtab experiment. r=gvn

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2e3c0cf197a3

Comment 7

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Needed for an upcoming experiment happening in 94.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for beta approval when you get a chance.

Comment 9

[Scott [:thecount] Downe]

Comment on attachment 9244037 [details]
Bug 1733675 - Fixes some nits in Pocket newtab experiment.

Beta/Release Uplift Approval Request

• User impact if declined: User experience won't be as polished around an experiment we'll be running in 94.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: To test:

Generic changes:

1. Set browser.newtabpage.activity-stream.discoverystream.compactLayout.enabled to true
2. Set browser.newtabpage.activity-stream.discoverystream.newFooterSection.enabled to true
3. Set browser.newtabpage.activity-stream.discoverystream.saveToPocketCard.enabled to true
4. Open a new tab.
5. Health topic in topics section should now be health & fitness to better match the target page. This change should persist in all configurations.
6. Privacy link should now be linking to https://www.mozilla.org/en-US/privacy/firefox/ dropping the "#suggest-relevant-content"
7. The save to pocket button while hovering over a card should have a slightly smaller icon.
8. new topics section should have clean and matching borders on top and bottom of topics in all media queries.
9. Turn off all the values in steps 1-3 and check nothing is different for steps6-8.

The new menu items:

1. Set browser.newtabpage.activity-stream.discoverystream.saveToPocketCard.enabled to true
2. Open the meatball menu.
3. EXPECTED: Should see only bookmark above the line break.
4. Click the save to Pocket button.
5. Open the meatball menu
6. EXPECTED: Should see "bookmark, archive, delete" above the line break.
7. EXPECTED: Clicking bookmark should update meantball menu item to remove bookmark.
8. EXPECTED: Archive/delete should work as expected.

The new message footer, this is the message displayed at the bottom of a card if you save to pocket or bookmark:

1. Set browser.newtabpage.activity-stream.discoverystream.compactLayout.enabled to true
2. Open a new tab
3. Click save to pocket from meatball menu in 1 card.
4. Click bookmark from the meatball menu in another card.
5. EXPECTED: Should be slightly smaller than before bookmark/savetopocket messages than before.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Early in the beta cycle, and the changes are mostly styling changes.
• String changes made/needed: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244037 [details]
Bug 1733675 - Fixes some nits in Pocket newtab experiment.

Approved for 94.0b4.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eb67ef17996c