1733688 - MR2 [about:welcome] - Update Theme picker variations selector UI

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to
a) add animation
b) update VariationsCircle as per final figma assets:
https://www.figma.com/file/blhdnzQOhWYKcdiCzywMuG/MR2-Onboarding?node-id=1783%3A111808

Comment 1

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]: MR2 new user onboarding UI fixes

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1733688 - Add background to theme variations selector r?pdahiya

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f38124d29f5
Add background to theme variations selector r=pdahiya

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 7f38124d29f5 (Bug 1733688) for causing newtab failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=PIvqaGoQS-e6rSJNo1xPBQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7f38124d29f5ea5788d18cd5ca8972d52d5229c3

Log: https://treeherder.mozilla.org/logviewer?job_id=354080328&repo=autoland&lineNumber=91

Backout: https://hg.mozilla.org/integration/autoland/rev/b69af85ff8aaa1953667606557b1b63a36cdf123

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/949908c22190
Add background to theme variations selector r=pdahiya

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/949908c22190

Comment 7

[Punam Dahiya [:pdahiya]]

Tests fixed by Ed's updated patch

Comment 8

[Ed Lee :Mardak]

Comment on attachment 9244603 [details]
Bug 1733688 - Add background to theme variations selector r?pdahiya

Beta/Release Uplift Approval Request

• User impact if declined: New users don't see polished theme/colorway screen with smooth transitions
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open about:welcome

2. Go to colorway screen with transitions

• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Mainly css changes with some html/react changes to support transitions
• String changes made/needed: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244603 [details]
Bug 1733688 - Add background to theme variations selector r?pdahiya

Approved for 94.0b5.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f429cf448875

Comment 11

[Robert Martin [:romartin], Ecosystem QA]

Marking this issue as Verified based on the work done for the feature. For more information see QA-1202.