Closed Bug 1733705 Opened 3 years ago Closed 3 years ago

python-mozbuild tests are failing when run on R8 osx 10.15

Categories

(Testing :: General, defect)

Default
defect

Tracking

(firefox94 fixed)

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file)

we have migrated everything else from the R7 -> R8, but there is a dangling item of the mozbuild tests.

At first I thought this was a py2->py3 issue, but that is not the case.

What is happening is that we generate some files, then build a tar.gz of the files, then get an sha1 hash and expect it to equal a value. On all OS versions this is the same, but for some reason while running on the R8, this fails.

this is the line of code in question:
https://searchfox.org/mozilla-central/source/python/mozbuild/mozpack/test/test_archive.py#173

create_tar_gz_from_files(fh, files, filename="foobar", compresslevel=1)

if we remove compresslevel=1, the gzip.GzipFile() will default to compresslevel=9 and all 3 OS will have the same value again. Unfortunately the author and reviewer of this test case are no longer at Mozilla, nor are any of the other people who have worked on tests in that file.

I am inclined to remove compresslevel=1 and move forward.

Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92aec5b01cfd
mozbuild test migrate from r7 -> r8. r=releng-reviewers,gbrown
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: