don't consider the critical displayport in AboutToCheckerboard
Categories
(Core :: Panning and Zooming, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox97 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
|
Assignee | |
Comment 1•3 years ago
|
||
With the old layers backend we had low precision buffer code controlled via the pref layers.low-precision-buffer that was used on android. We would expand the displayport by 4x and then paint it as 1/4 the resolution, and then we would have a critical displayport without the 4x multipler that we would paint at the real resolution. The code to do the painting at the lower resolution was in the layers backend and has since been removed. (This is okay because webrender doesn't rasterize all of the content in the displayport.) So the critical displayport or displayport are no longer treated differently anywhere. Except a few pieces of code that should be fixed/changed/removed. This patch being one of them.
Using the critical display port here is incorrect: the display port and critical display port have the same status with regards to rasterized content as well as the same status with regards to webrender having the displaylist of the content to be able to rasterize.
AboutToCheckerboard is only used in AsyncPanZoomController::OnScale to potentially schedule a RequestContentRepaint sooner, so this should have a small effect in practice.
|
||
Updated•3 years ago
|
|
||
Comment 2•3 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tnikkel, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Comment 3•3 years ago
|
||
That's on purpose. We've landed a bunch of other code changes around this area of code, in particular bug 1733732, and I want to wait for any potential fall out before touching this area of code.
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb9392c698c3 Don't consider the critical displayport in AboutToCheckerboard. r=botond
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
|
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
Description
•