1733762 - [wpt-sync] Sync PR 31002 - Put the LCP invisible image optimization behind a flag

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31002 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31002
Details from upstream follow.

Yoav Weiss <[e-mail]> wrote:

Put the LCP invisible image optimization behind a flag

LCP is not currently calculated for images that are initially invisible,
for optimization purposes. This results in correctness issues, where the
LCP image is not being reported.
This CL puts that optimization behind a flag, so that we can experiment
with turning it off.

Bug: 1249622
Change-Id: I2d2bcb03747f874acab7d45c77a5d25d6d319bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3178913
Commit-Queue: Yoav Weiss \<[e-mail]>
Reviewed-by: Nicolás Peña Moreno \<[e-mail]>
Reviewed-by: Philip Rogers \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#926365}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4bf96fc1bdf7a088fd2a48e8d828b73707ed258f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/largest-contentful-paint/initially-invisible-images.html
Image visibility: out-of-viewport images are observable by LargestContentfulPaint once they become visible.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ec3271f01b1
[wpt PR 31002] - Put the LCP invisible image optimization behind a flag, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e63c75cde2d5
[wpt PR 31002] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6ec3271f01b1
https://hg.mozilla.org/mozilla-central/rev/e63c75cde2d5