Closed Bug 1733780 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31036 - [WebTransport] Check event type before using its properties

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox95 fixed)

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31036 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31036
Details from upstream follow.

Yutaka Hirano <yhirano@chromium.org> wrote:

[WebTransport] Check event type before using its properties

The below code is problematic

if self._session_stream_id == event.stream_id and
isinstance(event, WebTransportStreamDataReceived):

because it uses event's property before checking its type. This
leads to errors when event without stream_id comes here. This
change fixes that.

PR 31036 applied with additional changes from upstream: c15c7aa204e35bdf2a7e1b5cd827e8d8d95a14d3, 96b23e1d1cedf7b93a5013143036f4b7cf0404ab, c9801a7b46ad1a67c3d50322ba14b227a2da669f, 7ac331544d166f06d6fb42df3b1a678518a4d74f
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5990118c68f
[wpt PR 31036] - [WebTransport] Check event type before using its properties, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/a5990118c68f

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.