Closed Bug 1733836 Opened 1 year ago Closed 1 year ago

Perma build bustages on WasmJS error: no type named 'TagType' in namespace 'js::wasm'; did you mean 'ValType'? when Gecko 94 merges to Beta on 2021-10-04

Categories

(Core :: JavaScript: WebAssembly, defect)

defect

Tracking

()

VERIFIED FIXED
94 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox92 --- unaffected
firefox93 --- unaffected
firefox94 blocking verified

People

(Reporter: imoraru, Assigned: asumu)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

[Tracking Requested - why for this release]:

Central-as-beta simulation:
How to run these simulations:

Failure log:

[task 2021-10-03T12:27:09.282Z] 12:27:09     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/js/src/frontend'
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -o Parser.o -c  -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/js/src/frontend -I/builds/worker/workspace/obj-build/js/src/frontend -I/builds/worker/workspace/obj-build/js/src -I/builds/worker/checkouts/gecko/js/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/js/src/js-confdefs.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wshadow-uncaptured-local -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fsanitize=thread -fcrash-diagnostics-dir=/builds/worker/artifacts -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fomit-frame-pointer -funwind-tables -fno-strict-aliasing -Werror=format -Wno-shadow -fexperimental-new-pass-manager  -MD -MP -MF .deps/Parser.o.pp   /builds/worker/checkouts/gecko/js/src/frontend/Parser.cpp
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -  In file included from /builds/worker/checkouts/gecko/js/src/frontend/Parser.cpp:20:
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -  In file included from /builds/worker/checkouts/gecko/js/src/frontend/Parser.h:179:
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -  In file included from /builds/worker/checkouts/gecko/js/src/frontend/BytecodeCompiler.h:19:
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -  In file included from /builds/worker/checkouts/gecko/js/src/vm/Scope.h:42:
[task 2021-10-03T12:27:09.285Z] 12:27:09    ERROR -  /builds/worker/checkouts/gecko/js/src/wasm/WasmJS.h:509:59: error: no type named 'TagType' in namespace 'js::wasm'; did you mean 'ValType'?
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -    static WasmTagObject* create(JSContext* cx, const wasm::TagType& tagType,
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -                                                      ~~~~~~^~~~~~~
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -                                                            ValType
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -  /builds/worker/checkouts/gecko/js/src/wasm/WasmValType.h:661:7: note: 'ValType' declared here
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -  using ValType = PackedType<ValTypeTraits>;
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -        ^
[task 2021-10-03T12:27:09.285Z] 12:27:09     INFO -  In file included from /builds/worker/checkouts/gecko/js/src/frontend/Parser.cpp:20:
[task 2021-10-03T12:27:09.286Z] 12:27:09     INFO -  In file included from /builds/worker/checkouts/gecko/js/src/frontend/Parser.h:179:
[task 2021-10-03T12:27:09.286Z] 12:27:09     INFO -  In file included from /builds/worker/checkouts/gecko/js/src/frontend/BytecodeCompiler.h:19:
[task 2021-10-03T12:27:09.286Z] 12:27:09     INFO -  In file included from /builds/worker/checkouts/gecko/js/src/vm/Scope.h:42:

Asumu, can you please take a look? It seems that your latest work on Bug 1732782 is causing this perma build bustages on beta-sim.

Flags: needinfo?(asumu)

There are also 2 build bustages that fail with a different failure line in the failure summary but in the log is the same problem as the one that this bug was made for.

Windows 2012 x64 opt Spidermonkey builds p

Windows 2012 x64 asan Bo

Assignee: nobody → asumu
Status: NEW → ASSIGNED

Sorry for the bustage! I attached a patch that should fix it (seems to build and test fine with/without exceptions locally). Running release sim here: https://treeherder.mozilla.org/jobs?repo=try&revision=f859f8512649eefd3951201003182cfc1275caf9 and mach try auto here https://treeherder.mozilla.org/jobs?repo=try&revision=75f467040051983809265d368b1aec2a09cda75f

Note: I'll be away from computer until afternoon PDT on 4 Oct so I won't be able to make any updates (if needed) to the patch until then.

Flags: needinfo?(asumu)

Thank you for the quick fix. Lars: Could you review the change? This Monday is the merge day from central to beta.

Flags: needinfo?(lhansen)
Flags: needinfo?(lhansen)
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/autoland/rev/06e67beeafc2
Fix build issue with wasm::TagType. r=rhunt
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.