Closed Bug 1733938 Opened 4 months ago Closed 3 months ago

mTRRSkipReason telemetry should never be TRR_UNSET in telemetry.

Categories

(Core :: Networking: DNS, defect, P2)

defect

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- wontfix
firefox94 --- fixed
firefox95 --- fixed

People

(Reporter: valentin, Assigned: valentin)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [necko-triaged])

Attachments

(1 file)

This value is a placeholder and should not actually be reported to telemetry.
The fact that it is means we have a bug.

Based on the glam telemetry graph this regressed around 2021-07-26.
The most likely cause for the regression is bug 1719135.

Set release status flags based on info from the regressing bug 1719135

Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a0adc6ddb2b0
mTRRSkipReason telemetry should never be TRR_UNSET in telemetry r=nhnt11,kershaw,necko-reviewers

Set release status flags based on info from the regressing bug 1719135

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

The patch landed in nightly and beta is affected.
:valentin, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(valentin.gosu)

Comment on attachment 9244196 [details]
Bug 1733938 - mTRRSkipReason telemetry should never be TRR_UNSET in telemetry r=nhnt11,kershaw

Beta/Release Uplift Approval Request

  • User impact if declined: No "user" impact, but TRR telemetry will be slightly off. We use telemetry to verify the implementation is working properly and to make strategic decisions and inferences regarding the usage of this feature.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: Verified using glam that the 0 bucked dropped to 0% on the day we landed this
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change has a small footprint. We merely move some code earlier in the flow to make sure the skip reason is properly initialized.
    We also added a debug_assert that the skip reason is never unset when the DNS resolution is complete.
  • String changes made/needed:
Flags: needinfo?(valentin.gosu)
Attachment #9244196 - Flags: approval-mozilla-beta?

Comment on attachment 9244196 [details]
Bug 1733938 - mTRRSkipReason telemetry should never be TRR_UNSET in telemetry r=nhnt11,kershaw

Approved for 94.0b8.

Attachment #9244196 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.