1734009 - Pass color-related arguments down to the non-native theme in a more convenient way.

Status: RESOLVED FIXED

(Core :: Widget, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1734009 - Pass color-related arguments down to the non-native theme in a more convenient way. r=mstange,dholbert

This avoids adding yet another parameter for the light/dark
color-scheme.

This shouldn't have any behavior change, but is a prerequisite to
implement dark form controls on the non-native theme.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29696aad4323
Pass color-related arguments down to the non-native theme in a more convenient way. r=dholbert

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/29696aad4323

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9244255 [details]
Bug 1734009 - Pass color-related arguments down to the non-native theme in a more convenient way. r=mstange,dholbert

Beta/Release Uplift Approval Request

• User impact if declined: Needed for bug 1734115.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: N/A
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple refactoring, doesn't change behavior.
• String changes made/needed: none

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9244255 [details]
Bug 1734009 - Pass color-related arguments down to the non-native theme in a more convenient way. r=mstange,dholbert

Approved for 94.0b6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ba5639fa9a0