Closed Bug 1734009 Opened 2 years ago Closed 2 years ago

Pass color-related arguments down to the non-native theme in a more convenient way.

Categories

(Core :: Widget, task)

Product:
Core
Component:
Widget
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed
firefox95 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1734009 - Pass color-related arguments down to the non-native theme in a more convenient way. r=mstange,dholbert
48 bytes, text/x-phabricator-request
diannaS
: approval-mozilla-beta+
Details | Review
No description provided.

This avoids adding yet another parameter for the light/dark
color-scheme.

This shouldn't have any behavior change, but is a prerequisite to
implement dark form controls on the non-native theme.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29696aad4323
Pass color-related arguments down to the non-native theme in a more convenient way. r=dholbert
Blocks: 1734115

https://hg.mozilla.org/mozilla-central/rev/29696aad4323

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
No longer regressions: 1734176

Comment on attachment 9244255 [details]
Bug 1734009 - Pass color-related arguments down to the non-native theme in a more convenient way. r=mstange,dholbert

Beta/Release Uplift Approval Request

  • User impact if declined: Needed for bug 1734115.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: N/A
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple refactoring, doesn't change behavior.
  • String changes made/needed: none
Attachment #9244255 - Flags: approval-mozilla-beta?

Comment on attachment 9244255 [details]
Bug 1734009 - Pass color-related arguments down to the non-native theme in a more convenient way. r=mstange,dholbert

Approved for 94.0b6

Attachment #9244255 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.