Closed Bug 1734126 Opened 4 months ago Closed 3 months ago

The onboarding page is dismissed after a few seconds if navigating back from the "Thank you" page

Categories

(Firefox :: Messaging System, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
95 Branch
Iteration:
95.1 - Oct 4 - Oct 17
Tracking Status
firefox93 --- unaffected
firefox94 + verified
firefox95 --- verified

People

(Reporter: cmuntean, Assigned: emcminn)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

[Affected Versions]:

  • Firefox Nightly 95.0a1 (Build ID: 20211004215121)
  • Firefox Beta 94.0b1 (Build ID: 20211004193346)

[Affected Platforms]:

  • Windows 10 x64
  • macOS 10.15.7
  • Linux Mint 20

[Steps to reproduce]:

  1. Open the latest Nightly/Beta build.
  2. Open a New Tab page and navigate to the "about:welcome" page.
  3. Navigate through onboarding until the "Life in color" panel is displayed.
  4. Click on the "Not now" button.
  5. Click the browser's "Back" button.
  6. Wait a few seconds and observe the behavior.

[Expected results]:

  • The Onboarding is not dismissed.

[Actual results]:

  • The Onboarding is dismissed after a few seconds.

[Notes]:

  • After navigating back from the "Thank you" page, if you choose another theme, the selected theme remains applied after the Onboarding page is dismissed.
  • The issue is not reproducible for the Upgrade Spotlight modal since there is no option to return to the previous pages.
  • Attached is a screen recording of the issue.

We should add check for last screen (isLastScreen) before kicking in script here that navigates user to about:home https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/aboutwelcome/components/MultiStageProtonScreen.jsx#32

NI @emcminn to help debug , thanks!

Flags: needinfo?(emcminn)

Oh I thought we had done that! I can take this and look into it.

EDIT: We are actually doing that - we're checking for this.props.order === total; , which is the same check that happens in the isLastScreen const. Maybe we need to make the check more robust.

Flags: needinfo?(emcminn)
Assignee: nobody → emcminn

[Tracking Requested - why for this release]:MR2 new user onboarding fixes

Iteration: --- → 95.1 - Oct 4 - Oct 17
Priority: -- → P1
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64561c1f8749
Make sure the autoClose doesn't persist if we navigate away from the Thanks page r=pdahiya
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

I have verified this issue on the latest Nightly 95.0a1 build (Build ID: 20211013034420) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20 x64.

  • The Onboarding page is no longer dismissed if navigating back from the "Thank you" page.

Comment on attachment 9244872 [details]
Bug 1734126 - Make sure the autoClose doesn't persist if we navigate away from the Thanks page

Beta/Release Uplift Approval Request

  • User impact if declined: Users who navigate through about:welcome using the back/forward buttons will be auto-navigated to about:home once they have seen the "Thank You" page, possibly interrupting user action
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Adds checks to navigation on about:welcome pages only.
  • String changes made/needed: none
Attachment #9244872 - Flags: approval-mozilla-beta?

Comment on attachment 9244872 [details]
Bug 1734126 - Make sure the autoClose doesn't persist if we navigate away from the Thanks page

Approved for 94.0b6

Attachment #9244872 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified this issue on the latest Beta 94.0b6 (Build ID: 20211014201116) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20 x64.

  • The Onboarding page is no longer dismissed if navigating back from the "Thank you" page.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.