Closed Bug 1734150 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31119 - SELECT: Fix deselection behavior on leaving the "multiple" mode

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31119 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31119
Details from upstream follow.

Kent Tamura <tkent@chromium.org> wrote:

SELECT: Fix deselection behavior on leaving the "multiple" mode

If

  • the SELECT switched from the "multiple" mode,
  • it had two or more selected OPTIONs, and
  • last_on_change_option_ was the first selected OPTION,
    we missed to deselect OPTIONs other than the first one due to the fast
    path of DeselectItemsWithoutValidation().

This CL clears last_on_change_option_ before calling
DeselectItemsWithoutValidation().

Bug: 1245443
Change-Id: Ib9cc4a4770d99ed6782edc73fd8ff1fcb3d8738b
Reviewed-on: https://chromium-review.googlesource.com/3205138
WPT-Export-Revision: 53b7fdb3bfa6eb87b16a8c67464a40f4ffb6658e

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS: 3

Chrome

OK : 1
PASS: 2
FAIL: 1

Safari

OK : 1
PASS: 3

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26bda823c598
[wpt PR 31119] - SELECT: Fix deselection behavior on leaving the "multiple" mode, a=testonly

https://hg.mozilla.org/mozilla-central/rev/26bda823c598

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.